fix: copy the description of the option to its alias in completion #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
requested changes
Nov 21, 2022
lib/completion.ts
Outdated
| @@ -258,7 +258,9 @@ export class Completion implements CompletionInstance { | |||
| if (!this.zshShell) { | |||
| completions.push(dashes + key); | |||
| } else { | |||
| const desc = descs[key] || ''; | |||
| const aliasKey = this?.aliases?.[key]?.[0]; | |||
There was a problem hiding this comment.
what about cases where there are multiple aliases associated with a key? should this be a loop?
There was a problem hiding this comment.
Oh, Thank you. Yes, sometimes the this?.aliases?.[key]?.[0] will be another alias without a description.
I will make it a loop.
|
@bcoe |
bcoe
approved these changes
Dec 28, 2022
|
@mshrtsr thank you for the contribution 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2268.
I find the original option for the alias and copy its description to the alias.
As a result, the option and its alias are collected together and aligned in the completion.