-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Comparing changes
Open a pull request
base repository: yarnpkg/berry
base: 4308dca8091438e8f88682e59ef5ba5bc72241ca
head repository: yarnpkg/berry
compare: 450097c303ab0247f131291ed6916bffaa42d5f8
- 6 commits
- 16 files changed
- 2 contributors
Commits on May 1, 2024
-
build(compat): fix building TypeScript patches (#6186)
**What's the problem this PR addresses?** Depending on the version of Node.js and npm you have available; building the TypeScript patches might not work. **How did you fix it?** - Since "recent" versions of TypeScript have a Volta config specifying the Node.js and npm versions to use, change the script to always use Volta to run `node` and `npm`. - For older versions without a complete Volta config I've added one. - Install using `npm ci` when a lockfile is present as using `npm install` causes some TypeScript builds to fail. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Configuration menu - View commit details
-
Copy full SHA for 1c79a81 - Browse repository at this point
Copy the full SHA 1c79a81View commit details -
build(compat): use a treeless TypeScript clone (#6193)
**What's the problem this PR addresses?** Building the latest TypeScript patch requires fetching https://github.com/arcanis/typescript, https://github.com/microsoft/typescript, and https://github.com/merceyz/typescript which, according to git, requires fetching 1.87 GiB, 452 MiB, and 42 MiB of data and produces a 2.7GB `.git` folder. **How did you fix it?** Fork TypeScript to https://github.com/yarnpkg/TypeScript and push the branches required to build all the patches to it and change the script to use a treeless clone of it which only needs to fetch 55 MiB of data and produces a 74MB `.git` folder. Depends on - #6186 **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Configuration menu - View commit details
-
Copy full SHA for 4c567f8 - Browse repository at this point
Copy the full SHA 4c567f8View commit details -
fix(compat): update patch for
typescript@5.5.0-beta
(#6248)**What's the problem this PR addresses?** The PnP compatibility patch for TypeScript doesn't apply to `typescript@5.5.0-beta`. Ref microsoft/TypeScript#35206 **How did you fix it?** Rebased it. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Configuration menu - View commit details
-
Copy full SHA for 893e1ab - Browse repository at this point
Copy the full SHA 893e1abView commit details
Commits on May 2, 2024
-
fix(sdks): only patch typescript entry point for >= 5.5 (#6263)
**What's the problem this PR addresses?** The SDK changes in #6248 broke support for older TypeScript versions. I tested it on `5.4.1-rc` (master) and it was fine but it crashes on 5.2.0-beta (https://github.com/yarnpkg/berry/blob/4308dca8091438e8f88682e59ef5ba5bc72241ca/package.json#L26) **How did you fix it?** Check the TypeScript version and only apply the patch if needed. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Configuration menu - View commit details
-
Copy full SHA for a0186c8 - Browse repository at this point
Copy the full SHA a0186c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cb1032 - Browse repository at this point
Copy the full SHA 2cb1032View commit details -
| Package name | Version | | --- | --- | | `@yarnpkg/cli` | `3.8.2` | | `@yarnpkg/plugin-compat` | `3.1.19` | | `@yarnpkg/sdks` | `2.7.4` |
Configuration menu - View commit details
-
Copy full SHA for 450097c - Browse repository at this point
Copy the full SHA 450097cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4308dca8091438e8f88682e59ef5ba5bc72241ca...450097c303ab0247f131291ed6916bffaa42d5f8