Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: yarnpkg/berry
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b7621f0736ef7ed423672392882d68592d61c81
Choose a base ref
...
head repository: yarnpkg/berry
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9a853e35cfe44d1cbd17b9739f68e90d1c79c96e
Choose a head ref
  • 19 commits
  • 1,027 files changed
  • 13 contributors

Commits on Mar 4, 2024

  1. Sync master with the changes from master

    yarnbot committed Mar 4, 2024
    Copy the full SHA
    2aa53d1 View commit details

Commits on Mar 10, 2024

  1. fix(extensions): eslint-import-resolver-vite@<2.0.1 (#6154)

    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    pzmosquito/eslint-import-resolver-vite#22
    
    **How did you fix it?**
    <!-- A detailed description of your implementation. -->
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    
    ---------
    
    Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
    n0099 and merceyz authored Mar 10, 2024
    Copy the full SHA
    2d6a7ab View commit details
  2. chore: fix typo: overriden -> overridden (#6155)

    Co-authored-by: MaΓ«l Nison <nison.mael@gmail.com>
    junhoyeo and arcanis authored Mar 10, 2024
    Copy the full SHA
    daa5747 View commit details

Commits on Mar 27, 2024

  1. Adds ts-nocheck to the PnP file (#6183)

    **What's the problem this PR addresses?**
    
    The PnP file is fairly large; it seems that parsing it is difficult for
    TypeScript on projects configured with `checkJs`, even if it doesn't
    contain `// @ts-check`. Adding `// @ts-nocheck` to the file seemed to
    improve the situation.
    
    **How did you fix it?**
    
    Adds `// @ts-nocheck` to the generated `.pnp.cjs` file.
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    arcanis authored Mar 27, 2024
    Copy the full SHA
    c9d5a4c View commit details
  2. Improve libc presence detection (#6170)

    **What's the problem this PR addresses?**
    
    On certain Linux distributions, `/usr/bin/ldd` does not contain the
    string "GLIBC", but "libc". This is the case in popular distros such as
    openSUSE, Amazon Linux, Fedora, RHEL, Arch, and more. On these
    distributions, the current version of yarn falls back to
    `process.report.getReport()`, which is known to have performance issues
    in some instances.
    
    **How did you fix it?**
    
    Add a check for the presence of the value `libc` in addition to the
    existing check for `GLIBC`. This allows more Linux users to benefit from
    the fast-path that does not rely on `process.report.getReport()`.
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    dstaley authored Mar 27, 2024
    Copy the full SHA
    a3e5695 View commit details

Commits on Apr 10, 2024

  1. Exclude binaries when searching in VS Code (#6213)

    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    When searching in VS Code, the precompiled binaries often show up in the
    results, because whatever source code matched the search is included in
    the binary.
    
    **How did you fix it?**
    <!-- A detailed description of your implementation. -->
    
    Added search exclusions for precompiled binaries in VS Code settings
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    clemyan authored Apr 10, 2024
    Copy the full SHA
    a4c99d5 View commit details
  2. build(compat): fix building TypeScript patches (#6186)

    **What's the problem this PR addresses?**
    
    Depending on the version of Node.js and npm you have available; building
    the TypeScript patches might not work.
    
    **How did you fix it?**
    
    - Since "recent" versions of TypeScript have a Volta config specifying
    the Node.js and npm versions to use, change the script to always use
    Volta to run `node` and `npm`.
    - For older versions without a complete Volta config I've added one.
    - Install using `npm ci` when a lockfile is present as using `npm
    install` causes some TypeScript builds to fail.
    
    **Checklist**
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    merceyz authored Apr 10, 2024
    Copy the full SHA
    17de52a View commit details
  3. feat(builder): add --metafile flag (#6212)

    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    resolves #6211
    
    ...
    
    **How did you fix it?**
    
    - added a boolean CLI switch to `builder build {bundle,plugin}` called
    `--metafile`, defaults to `false`
    - if CLI switch 
      - is `false`,  then the `esbuild` in instructed to NOT emit `metafile`
      - is `true`, then ...
        - the `esbuild` in instructed to emit `metafile`
    - the `metafile` data is written to target file
    `bundles/${name}.meta.json`
        - the target file is announced in the summary  
          example ourput:   
          ```shellSession
          $ builder build plugin --metafile 
          ➀ YN0000: β”Œ Building @yarnpkg/plugin-cyclonedx
          ➀ YN0000: β”” Completed in 8s 619ms
          
          ➀ YN0000: βœ“ Done building @yarnpkg/plugin-cyclonedx!
    ➀ YN0000: ? Bundle path:
    /.../cyclonedx-node-yarn/bundles/@yarnpkg/plugin-cyclonedx.js
          ➀ YN0000: ? Bundle size: 771.52 KiB
    ➀ YN0000: ? Bundle meta:
    /.../cyclonedx-node-yarn/bundles/@yarnpkg/plugin-cyclonedx.meta.json
          ```
     
    <!-- A detailed description of your implementation. -->
    
    ...
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    
    ---------
    
    Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
    Co-authored-by: merceyz <merceyz@users.noreply.github.com>
    jkowalleck and merceyz authored Apr 10, 2024
    Copy the full SHA
    4a889dc View commit details
  4. feat(plugin-typescript): check workspace tsconfig.json (#6175)

    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    Given the following monorepo setup, `plugin-typescript` is currently not
    enabled by default in the `foo` workspace, as it only checks that a
    `tsconfig.json` exists at the root of the project:
    
    ```
    package.json
    workspace/foo/package.json
    workspace/foo/tsconfig.json
    ```
    
    I also found the [current `README` of
    `plugin-typescript`](https://github.com/yarnpkg/berry/blob/daa574791b3b2df01e76c1fdfd9c975050a0fb9d/packages/plugin-typescript/README.md)
    not to be helpful in diagnosing my issue
    
    **How did you fix it?**
    <!-- A detailed description of your implementation. -->
    
    I've added a check to see if the current workspace had a `tsconfig.json`
    
    I've also added a Configuration section to
    `plugin-typescript/README.md`, to help users find the
    `tsEnableAutoTypes` option.
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    - I have only bumped `@yarnpkg/plugin-typescript` and `@yarnpkg/cli`,
    let me know if I should also select the other plugins/core etc.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    nmussy authored Apr 10, 2024
    Copy the full SHA
    aa4029d View commit details
  5. build(compat): use a treeless TypeScript clone (#6193)

    **What's the problem this PR addresses?**
    
    Building the latest TypeScript patch requires fetching
    https://github.com/arcanis/typescript,
    https://github.com/microsoft/typescript, and
    https://github.com/merceyz/typescript which, according to git, requires
    fetching 1.87 GiB, 452 MiB, and 42 MiB of data and produces a 2.7GB
    `.git` folder.
    
    **How did you fix it?**
    
    Fork TypeScript to https://github.com/yarnpkg/TypeScript and push the
    branches required to build all the patches to it and change the script
    to use a treeless clone of it which only needs to fetch 55 MiB of data
    and produces a 74MB `.git` folder.
    
    Depends on 
    - #6186
    
    **Checklist**
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    merceyz authored Apr 10, 2024
    Copy the full SHA
    ded6091 View commit details
  6. Migrate docs to Docusaurus v3 (#6133)

    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    The docs website is on Docsaurus v2 which is not the latest major
    version
    
    Closes #5918
    Closes #6153
    
    **How did you fix it?**
    <!-- A detailed description of your implementation. -->
    
    Migrate to Docsaurus v3.
    
    There are other improvements to the build process and website I'd like
    to make, but I have left them out and kept most of the logic intact
    since the migration is quite a large undertaking already.
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    clemyan authored Apr 10, 2024
    Copy the full SHA
    c64644a View commit details

Commits on Apr 20, 2024

  1. fix(version) use correct counter placeholder in documentation (#6241)

    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    The documentation mentions `%d` but the code uses `%n`.
    
    
    https://github.com/yarnpkg/berry/blob/c64644ae88ba42090ab9b87da0b09601d4218b0c/packages/plugin-version/sources/commands/version/apply.ts#L76-L78
    
    **How did you fix it?**
    <!-- A detailed description of your implementation. -->
    
    Update the code
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    bgotink authored Apr 20, 2024
    Copy the full SHA
    22758ae View commit details

Commits on Apr 23, 2024

  1. Use title for issue sesctions (#6244)

    In markdown, syntax have meaning. Those shouldn't be bold text, but
    titles:
    - semantically it suggests something different
    - `**text**` are easy to be removed as they could be interpreted as
    placeholders
    - having titles allows deep linking
    Ayc0 authored Apr 23, 2024
    Copy the full SHA
    52252b0 View commit details

Commits on May 1, 2024

  1. fix(docs): Fixes SysGears logo in the README and SysGears name spelli…

    …ng (#6245)
    
    **What's the problem this PR addresses?**
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    At the moment the image to SysGears logo is broken, because the URL has
    changed to the `sysgears.com` domain from `cdn3.sysgears.com` subdomain.
    
    **How did you fix it?**
    <!-- A detailed description of your implementation. -->
    
    I have updated the URL to the logo to point at GitHub, so that Yarn
    weren't affected by external website changes. I also updated spelling of
    the SysGears name from Sysgears to SysGears, as the latter is more
    correct.
    
    **Checklist**
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    larixer authored May 1, 2024
    Copy the full SHA
    c8c59ff View commit details
  2. fix(compat): update patch for typescript@5.5.0-beta (#6248)

    **What's the problem this PR addresses?**
    
    The PnP compatibility patch for TypeScript doesn't apply to
    `typescript@5.5.0-beta`.
    
    Ref microsoft/TypeScript#35206
    
    **How did you fix it?**
    
    Rebased it.
    
    **Checklist**
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    merceyz authored May 1, 2024
    Copy the full SHA
    c7c0767 View commit details
  3. Fix parser stringify subshell brackets (#6254)

    ## What's the problem this PR addresses?
    
    With `@yarnpkg/parsers`, stringifying a subshell (e.g. `echo $(echo a)`)
    uses the wrong brackets (e.g. `echo ${echo a}`)
    
    ## How did you fix it?
    
    Change to use the correct brackets.
    
    ## Checklist
    
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    clemyan authored May 1, 2024
    Copy the full SHA
    8d8b318 View commit details
  4. Simplify documentation of "constraints" overview (#6257)

    The current documentation overview for
    [Constraints](https://yarnpkg.com/features/constraints) reads somewhat
    like a sales pitch, rather than documentation. It's a bit wordy, and
    kind of grammatically incorrect/confusing. It might be more beneficial
    to mention "enforcement of workspace package rules" as the main point,
    rather than towards the end of the description. Additionally,
    constraints can be used for a large number of needs that are not
    necessarily "basic" ones.
    
    I'd be fine with expanding the example list, but being sure to specify
    that these are just examples of how constraints are commonly used.
    They're not the limit of the capability.
    
    ## What's the problem this PR addresses?
    
    Unclear documentation.
    
    ## How did you fix it?
    
    Made it a bit more clear and simple.
    
    ## Checklist
    
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [ ] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [ ] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [ ] I will check that all automated PR checks pass before the PR gets
    reviewed.
    jeremy-daley-kr authored May 1, 2024
    Copy the full SHA
    df5d1c2 View commit details

Commits on May 2, 2024

  1. fix(sdks): only patch typescript entry point for >= 5.5 (#6263)

    **What's the problem this PR addresses?**
    
    The SDK changes in #6248 broke
    support for older TypeScript versions.
    I tested it on `5.4.1-rc` (master) and it was fine but it crashes on
    5.2.0-beta
    (https://github.com/yarnpkg/berry/blob/4308dca8091438e8f88682e59ef5ba5bc72241ca/package.json#L26)
    
    **How did you fix it?**
    
    Check the TypeScript version and only apply the patch if needed.
    
    **Checklist**
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    merceyz authored May 2, 2024
    Copy the full SHA
    f994c2b View commit details
  2. Releasing 13 new packages

    | Package name | Version |
    | --- | --- |
    | `@yarnpkg/cli` | `4.2.0` |
    | `@yarnpkg/extensions` | `2.0.2` |
    | `@yarnpkg/plugin-compat` | `4.0.4` |
    | `@yarnpkg/plugin-version` | `4.0.2` |
    | `@yarnpkg/builder` | `4.1.0` |
    | `@yarnpkg/sdks` | `3.1.1` |
    | `@yarnpkg/core` | `4.0.4` |
    | `@yarnpkg/plugin-npm-cli` | `4.0.3` |
    | `@yarnpkg/parsers` | `3.0.1` |
    | `@yarnpkg/shell` | `4.0.1` |
    | `@yarnpkg/plugin-typescript` | `4.1.0` |
    | `@yarnpkg/plugin-pnp` | `4.0.3` |
    | `@yarnpkg/pnp` | `4.0.3` |
    yarnbot committed May 2, 2024
    Copy the full SHA
    9a853e3 View commit details
Showing 1,027 changed files with 17,802 additions and 13,813 deletions.
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ packages/yarnpkg-libzip/sources/libzipSync.js binary linguist-generate

# Hide .yarn and docs from GitHub's language detection
/.yarn/** linguist-vendored
/docs/** linguist-documentation
/packages/docusaurus/** linguist-documentation

# Mark built javascript binaries as generated
# Without this, the repo is marked as >90% javascript, while most code is actually typescript
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -16,23 +16,23 @@ assignees: ''
- [ ] I'd be willing to implement this feature ([contributing guide](https://yarnpkg.com/advanced/contributing))
- [ ] This feature is important to have in this repository; a contrib plugin wouldn't do

**Describe the user story**
## Describe the user story

A clear and concise description of what workflow is meant to be improved.
Example: "As a developer, I often want to do <something>, but I often face <problem>".

**Describe the solution you'd like**
## Describe the solution you'd like

A clear and concise description of what you want to happen. Consider that Yarn is used
by many people, and your particular use case might not make sense to implement in the core.

**Describe the drawbacks of your solution**
## Describe the drawbacks of your solution

This section is important not only to identify future issues, but also for us to see whether
you thought through your request. When filling it, ask yourself what are the problems we could
have maintaining what you propose. How often will it break?

**Describe alternatives you've considered**
## Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered,
and why you think they wouldn't be good enough. Start by: why not make it a plugin?
9 changes: 6 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
**What's the problem this PR addresses?**
## What's the problem this PR addresses?

<!-- Describe the rationale of your PR. -->
<!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->

...

**How did you fix it?**
## How did you fix it?

<!-- A detailed description of your implementation. -->

...

**Checklist**
## Checklist

<!--- Don't worry if you miss something, chores are automatically tested. -->
<!--- This checklist exists to help you remember doing the chores when you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -38,9 +38,6 @@ package.tgz
/packages/yarnpkg-libui/sources/**/*.js
/packages/yarnpkg-libui/sources/**/*.d.ts

# Only contains the Webpack cache
/packages/docusaurus/.yarn

# Used by /scripts/stable-versions-store.js
/scripts/stable-versions-store.json

Loading