Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: yarnpkg/berry
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab48d624e2490567be531b4e7c7145c5bc6e55f2
Choose a base ref
...
head repository: yarnpkg/berry
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d2afdfcf8819c449dc9784959ab5beb1389a4b26
Choose a head ref
  • 5 commits
  • 20 files changed
  • 4 contributors

Commits on Aug 2, 2024

  1. Sync master with the changes from master

    yarnbot committed Aug 2, 2024
    Copy the full SHA
    13d5b30 View commit details

Commits on Aug 10, 2024

  1. test: fix custom certification tests on Windows (#6450)

    ## What's the problem this PR addresses?
    
    The integration tests using custom certificates have been failing for
    quite a while on Windows with the error `RequestError: unsuitable
    certificate purpose`.
    
    ## How did you fix it?
    
    This error was caused by the test CA certificate used; it was not
    configured to be used as a CA when it was generated.
    
    The test script that generates the CA certificate has been updated to
    generate it correctly. I used the same configuration options used by the
    test suite of the `pem` library that we are using for certificate
    generation:
    https://github.com/Dexus/pem/blob/3d71b87cec08a565ce5e73e26dd18f53b9e1fdea/test/pem.spec.js#L856
    
    The problem does not seem to be specific to Windows; I was able to
    reproduce it locally on macOS as well. I don't yet know why it's passing
    on CI for Ubuntu and macOS, but not for Windows. Perhaps some difference
    in the images, like the OpenSSL version (they should all be using
    OpenSSL v1.1.1, but I've seen reports of Windows having v3 installed as
    well).
    
    ## Checklist
    
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    Gudahtt authored Aug 10, 2024
    Copy the full SHA
    7495114 View commit details

Commits on Aug 11, 2024

  1. feat(nm): Add support for user-defined <workspace>/node_modules symli…

    …nks (#6416)
    
    ## What's the problem this PR addresses?
    
    <!-- Describe the rationale of your PR. -->
    <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->
    
    Fixes: #6415 
    
    ## How did you fix it?
    
    <!-- A detailed description of your implementation. -->
    
    Now the `node-modules` linker do not try to delete or recreate
    `<any_workspace>/node_modules` directories if they are symlinks and the
    underlying dependencies were removed or newly added.
    
    ## Checklist
    
    <!--- Don't worry if you miss something, chores are automatically
    tested. -->
    <!--- This checklist exists to help you remember doing the chores when
    you submit a PR. -->
    <!--- Put an `x` in all the boxes that apply. -->
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    
    <!-- See
    https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
    for more details. -->
    <!-- Check with `yarn version check` and fix with `yarn version check
    -i` -->
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    
    <!-- The "Testing chores" workflow validates that your PR follows our
    guidelines. -->
    <!-- If it doesn't pass, click on it to see details as to what your PR
    might be missing. -->
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    larixer authored Aug 11, 2024
    Copy the full SHA
    7fab4f1 View commit details

Commits on Aug 24, 2024

  1. fix(compat): update patch for typescript@5.6.1-rc (#6461)

    **What's the problem this PR addresses?**
    
    The PnP compatibility patch for TypeScript doesn't apply to
    `typescript@5.6.1-rc`.
    
    Ref microsoft/TypeScript#35206
    
    **How did you fix it?**
    
    Rebased it.
    
    **Checklist**
    - [x] I have read the [Contributing
    Guide](https://yarnpkg.com/advanced/contributing).
    - [x] I have set the packages that need to be released for my changes to
    be effective.
    - [x] I will check that all automated PR checks pass before the PR gets
    reviewed.
    merceyz authored Aug 24, 2024
    Copy the full SHA
    80cb95e View commit details
  2. Releasing 3 new packages

    | Package name | Version |
    | --- | --- |
    | `@yarnpkg/cli` | `4.4.1` |
    | `@yarnpkg/plugin-compat` | `4.0.8` |
    | `@yarnpkg/plugin-nm` | `4.0.3` |
    yarnbot committed Aug 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d2afdfc View commit details
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ Features in `master` can be tried out by running `yarn set version from sources`
:::

- Fixes `preferInteractive` forcing interactive mode in non-TTY environments.
- `node-modules` linker now honors user-defined symlinks for `<workspace>/node_modules` directories

## 4.1.0

Original file line number Diff line number Diff line change
@@ -927,6 +927,7 @@ export const getHttpsCertificates = async () => {
csr,
clientKey,
selfSigned: true,
config: [`[v3_req]`, `basicConstraints = critical,CA:TRUE\``].join(`\n`),
});

const serverCSRResult = await createCSR({commonName: `localhost`});
Original file line number Diff line number Diff line change
@@ -1855,6 +1855,47 @@ describe(`Node_Modules`, () => {
}),
);

it(`should work with user-created <workspace>/node_modules symlinks`,
makeTemporaryEnv(
{
workspaces: [`ws`],
dependencies: {
},
},
{
nodeLinker: `node-modules`,
nmHoistingLimits: `workspaces`,
},
async ({path, run}) => {
await xfs.mkdirpPromise(ppath.join(path, `ws`));
const trueInstallDir = ppath.resolve(path, `target`);
await xfs.mkdirPromise(trueInstallDir);

await xfs.writeJsonPromise(ppath.join(path, `ws/${Filename.manifest}`), {
name: `ws`,
devDependencies: {
[`no-deps`]: `1.0.0`,
},
});

await xfs.symlinkPromise(trueInstallDir, ppath.join(path, `ws/node_modules`));

await run(`install`);

expect(xfs.existsSync(ppath.join(trueInstallDir, `no-deps`))).toBeTruthy();
expect(xfs.lstatSync(ppath.join(path, `ws/node_modules`)).isSymbolicLink()).toBeTruthy();

await xfs.writeJsonPromise(ppath.join(path, `ws/${Filename.manifest}`), {
name: `ws`,
});

await run(`install`);

expect(xfs.existsSync(ppath.join(trueInstallDir, `no-deps`))).toBeFalsy();
expect(xfs.lstatSync(ppath.join(path, `ws/node_modules`)).isSymbolicLink()).toBeTruthy();
}),
);

it(`should support supportedArchitectures`,
makeTemporaryEnv(
{
Loading