[Bug]: enableTransparentWorkspaces: false not respected, or dependency not installed

[nicolo-ribaudo]

Self-service

• I'd be willing to implement a fix

Describe the bug

In the Babel repository (tested with commit https://github.com/babel/babel/tree/7bbdf096aa49f43909f559756e55127f831344f3), when running this script from the top-level:

const chain = [
  "jest",
  "@jest/core",
  "jest-snapshot",
  "@babel/traverse",
  "@babel/code-frame",
  "@babel/highlight",
  "@babel/helper-validator-identifier",
];
const len = chain.map(n => n.length).reduce((a, b) => Math.max(a, b));

let prev = process.cwd();
for (const name of chain) {
  prev = require.resolve(name, { paths: [prev] });
  console.log(`Resolve ${name.padEnd(len)} -> ${prev}`);
}

it logs this output:

Resolve jest                               -> /home/nicolo/Documenti/dev/babel/babel/node_modules/jest/build/jest.js
Resolve @jest/core                         -> /home/nicolo/Documenti/dev/babel/babel/node_modules/@jest/core/build/jest.js
Resolve jest-snapshot                      -> /home/nicolo/Documenti/dev/babel/babel/node_modules/jest-snapshot/build/index.js
Resolve @babel/traverse                    -> /home/nicolo/Documenti/dev/babel/babel/node_modules/jest-snapshot/node_modules/@babel/traverse/lib/index.js
Resolve @babel/code-frame                  -> /home/nicolo/Documenti/dev/babel/babel/node_modules/jest-snapshot/node_modules/@babel/traverse/node_modules/@babel/code-frame/lib/index.js
Resolve @babel/highlight                   -> /home/nicolo/Documenti/dev/babel/babel/node_modules/jest-snapshot/node_modules/@babel/highlight/lib/index.js
Resolve @babel/helper-validator-identifier -> /home/nicolo/Documenti/dev/babel/babel/packages/babel-helper-validator-identifier/lib/index.js

This is a valid dependency chain (jest depends on jest-snapshot, which depends on @babel/traverse, etc.) and we use enableTransparentWorkspaces: false: I expect the last @babel/helper-validator-identifier to be resolved to somewhere inside node_modules, and not to the monorepo package.

To reproduce

const { writeFile } = require("fs").promises;

await packageJson({
  name: "@babel/helper-validator-identifier",
  version: "7.40.0"
},{ cwd: "packages/babel-helper-validator-identifier" })

await writeFile(".yarnrc.yml", `
  nodeLinker: node-modules
  enableTransparentWorkspaces: false
`);
await writeFile("index.js", `
  const chain = [
    "jest",
    "@jest/core",
    "jest-snapshot",
    "@babel/traverse",
    "@babel/code-frame",
    "@babel/highlight",
    "@babel/helper-validator-identifier",
  ];

  let prev = process.cwd();
  for (const name of chain) {
    prev = require.resolve(name, { paths: [prev] });
  }
  module.exports = prev;
`);

await packageJsonAndInstall({
  workspaces: ["packages/babel-helper-validator-identifier"],
  dependencies: {
    jest: "^27.2.0"
  }
});

const result = await node("index.js");

expect(result).toBe("???");

Environment

System:
    OS: Linux 5.11 Ubuntu 21.04 (Hirsute Hippo)
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 16.10.0 - /tmp/xfs-d2e13dcc/node
    Yarn: 3.0.2 - /tmp/xfs-d2e13dcc/yarn
    npm: 7.21.1 - ~/.npm-global/bin/npm

Additional context

This is causing the CI failure in babel/babel#13414

[yarnbot]

This issue reproduces on master:

Error: expect(received).toBe(expected) // Object.is equality

Expected: "???"
Received: {}
    at module.exports (evalmachine.<anonymous>:40:16)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async /github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:56:13
    at async executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:17:16)
    at async Object.executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:24:12)
    at async ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:25:38)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[nicolo-ribaudo]

I don't know how to write the Sherlock example: how can I "extract" the result of the node script? I expected to see something like Received: "/path/to/somewhere", not Received: {}.

[nicolo-ribaudo]

This seems to be fixed by #3438.