From af91e7cd684ca1ce6b7f6b24a1e2d4b92a942eeb Mon Sep 17 00:00:00 2001 From: Chih-Hsuan Yen Date: Thu, 31 Jan 2019 02:31:32 +0800 Subject: [PATCH] Fix handling of non-offline errors (#6968) * Fix handling of non-offline errors * Update CHANGELOG.md --- CHANGELOG.md | 4 ++++ src/util/request-manager.js | 2 ++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b78a703e9..a3cb321273 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa ## Master +- Fixes the error reporting for non-HTTP network errors (such as invalid certificates) + + [#6968](https://github.com/yarnpkg/yarn/pull/6968) - [**Chih-Hsuan Yen**](https://github.com/yan12125) + - Changes the location where the `--require ./.pnp.js` flag gets added into `NODE_OPTIONS`: now at the front (bis) [#6951](https://github.com/yarnpkg/yarn/pull/6951) - [**John-David Dalton**](https://twitter.com/jdalton) diff --git a/src/util/request-manager.js b/src/util/request-manager.js index 3e944f6b7f..60cdb442f2 100644 --- a/src/util/request-manager.js +++ b/src/util/request-manager.js @@ -401,6 +401,8 @@ export default class RequestManager { if (!queueForRetry(this.reporter.lang('offlineRetrying'))) { reject(err); } + } else { + reject(err); } };