Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn --modules-folder lib/ add requirejs #5715

Open
lplus opened this issue Apr 23, 2018 · 3 comments
Open

yarn --modules-folder lib/ add requirejs #5715

lplus opened this issue Apr 23, 2018 · 3 comments

Comments

@lplus
Copy link

lplus commented Apr 23, 2018

yarn --modules-folder lib/ add requirejs

why auto create node_modules folder

@ghost ghost assigned rally25rs Apr 23, 2018
@ghost ghost added the triaged label Apr 23, 2018
@rally25rs
Copy link
Contributor

The bin links end up still in node_modules

~/Projects/yarn-test 🐒   yarn init -y
yarn init v1.6.0
warning The yes flag has been set. This will automatically answer yes to all questions, which may have security implications.
success Saved package.json
✨  Done in 0.03s.

~/Projects/yarn-test 🐒   yarn --modules-folder lib/ add requirejs
yarn add v1.6.0
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ requirejs@2.3.5
info All dependencies
└─ requirejs@2.3.5
✨  Done in 0.24s.

~/Projects/yarn-test 🐒   ls lib/.bin
ls: lib/.bin: No such file or directory

~/Projects/yarn-test 🐒   ls node_modules/.bin/
r.js r_js

I'm not really sure if this is a bug or intentional since yarn run would look for and set up path for node_modules/.bin. @BYK @arcanis do either of you know if this is by design or a bug?

@arcanis
Copy link
Member

arcanis commented Apr 23, 2018

Not sure - I'd say it's a bug and --modules-folder should be taken into account by yarn run (but only as pre-run parameter, like --cwd).

@rafamerlin
Copy link

I tried to reproduce this issue locally and couldn't.
After checking for a bit I think this: #6850 fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants