Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Windows Incompatability Problem #6557

Closed
AlexMachin1997 opened this issue Oct 18, 2018 · 7 comments
Closed

Possible Windows Incompatability Problem #6557

AlexMachin1997 opened this issue Oct 18, 2018 · 7 comments

Comments

@AlexMachin1997
Copy link

Do you want to request a feature or report a bug?
I'm reporting a bug as suggested by Mael - https://twitter.com/arcanis/status/1053032265113055236

What is the current behavior?
The current behaviour is when "npx create-react-app my-app --use-pnp" command is run I get the following error
image

If the current behavior is a bug, please provide the steps to reproduce.

  • Download yarn 1.12 on windows 10
  • run the "npx create-react-app my-app --use-pnp"

What is the expected behavior?
The expected behaviour is that create-react-app should be created with plug and play functionality ie no node_Modules.

Please mention your node.js, yarn and operating system version.
Wndows 10 - 1803
NodeJS - 8.12.0
yarn - 1.12

Any additional notes required just let me know in the comments below.

@ghost ghost added the triaged label Oct 18, 2018
@arcanis
Copy link
Member

arcanis commented Oct 18, 2018

I think this is simply related to the following regexp, which doesn't cover absolute Windows paths:

https://github.com/yarnpkg/yarn/blob/master/src/util/generate-pnp-map-api.tpl.js#L36

cc @jdalton

@jdalton
Copy link
Contributor

jdalton commented Oct 18, 2018

Thanks for the ping. I'll dig into it.

@arcanis
Copy link
Member

arcanis commented Oct 19, 2018

Fixed in #6495 - the PR isn't ready to be landed yet (there's other incompatibilities we need to fix first, such as #6493), but it's a good start 😃

@jdalton
Copy link
Contributor

jdalton commented Oct 19, 2018

Beat me to it 😋

@arcanis
Copy link
Member

arcanis commented Nov 14, 2018

Now that the acceptance tests run on Azure, PnP is officially supported on Windows 👍

@AlexMachin1997
Copy link
Author

Awesome work guys 💪 👍 💯 💪

Sorry for incredibly late response, been super busy with my personal studies at university. Only just got around to checking all my notifications on Githhub.

Is this issue safe to close now?

@arcanis
Copy link
Member

arcanis commented Mar 6, 2019

Yup! 👍

@arcanis arcanis closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants