Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve none zero exit code #6925

Closed
zhigang1992 opened this issue Jan 15, 2019 · 3 comments · Fixed by #6926
Closed

Preserve none zero exit code #6925

zhigang1992 opened this issue Jan 15, 2019 · 3 comments · Fixed by #6926
Assignees
Labels

Comments

@zhigang1992
Copy link
Contributor

zhigang1992 commented Jan 15, 2019

I want to request a feature

Preserve none zero exit code.

I'm trying to create a Github Action.

https://developer.github.com/actions/creating-github-actions/accessing-the-runtime-environment/#exit-codes-and-statuses

To filter actions, it needs 78 as exit code:

index.js

const process = require('process');
process.exit(78)

npm start will yield 78, but yarn start will yield 1.

screen shot 2019-01-15 at 8 44 31 pm

Is there an option that already does this?

@ghost ghost assigned arcanis Jan 15, 2019
@ghost ghost added the triaged label Jan 15, 2019
@arcanis
Copy link
Member

arcanis commented Jan 15, 2019

Hm that sounds like a bug, I agree the status code should be preserved. Would you like to open a PR to fix this? I think it should be in executeLifecycle and/or run.js

@zhigang1992
Copy link
Contributor Author

Sure, will give it a try...

@zhigang1992
Copy link
Contributor Author

@arcanis please take a look at #6926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants