From 2ac738363ffe63392ae9233c443f7325541f8080 Mon Sep 17 00:00:00 2001 From: Jeff Valore Date: Sat, 22 Dec 2018 08:46:56 -0500 Subject: [PATCH 1/2] refactor(config): Remove rootModuleFolders variable which was not used anywhere. --- src/cli/commands/config.js | 1 - src/config.js | 12 ------------ 2 files changed, 13 deletions(-) diff --git a/src/cli/commands/config.js b/src/cli/commands/config.js index 1e35326d73..d884c2c39e 100644 --- a/src/cli/commands/config.js +++ b/src/cli/commands/config.js @@ -7,7 +7,6 @@ import buildSubCommands from './_build-sub-commands.js'; const CONFIG_KEYS = [ // 'reporter', - 'rootModuleFolders', 'registryFolders', 'linkedModules', // 'registries', diff --git a/src/config.js b/src/config.js index 97af68ac20..ee4a536da1 100644 --- a/src/config.js +++ b/src/config.js @@ -127,9 +127,6 @@ export default class Config { // linkedModules: Array; - // - rootModuleFolders: Array; - // linkFolder: string; @@ -317,10 +314,6 @@ export default class Config { if (this.registryFolders.indexOf(registry.folder) === -1) { this.registryFolders.push(registry.folder); } - const rootModuleFolder = path.join(this.cwd, registry.folder); - if (this.rootModuleFolders.indexOf(rootModuleFolder) === -1) { - this.rootModuleFolders.push(rootModuleFolder); - } } if (this.modulesFolder) { @@ -451,7 +444,6 @@ export default class Config { } _init(opts: ConfigOptions) { - this.rootModuleFolders = []; this.registryFolders = []; this.linkedModules = []; @@ -493,10 +485,6 @@ export default class Config { captureHar: !!opts.captureHar, }); - if (this.modulesFolder) { - this.rootModuleFolders.push(this.modulesFolder); - } - this.focus = !!opts.focus; this.focusedWorkspaceName = ''; From 49b7351ea5506fa51484c478af503da18cc7e77c Mon Sep 17 00:00:00 2001 From: Jeff Valore Date: Sat, 22 Dec 2018 08:51:35 -0500 Subject: [PATCH 2/2] update changelog for PR #6846 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0981085e9e..f0e4524111 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa ## Master +- Refactor/Remove `rootModuleFolders` variable which was not used anywhere. + + [#6846](https://github.com/yarnpkg/yarn/pull/6846) - [**Jeff Valore**](https://twitter.com/codingwithspike) + ## 1.13.0 - Implements a new `package.json` field: `peerDependenciesMeta`