Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat the ignore-scripts in yarnrc as a synonym to the cli arg #6983

Merged

Conversation

MichaReiser
Copy link
Contributor

Summary
Allow users to specify ignore-scripts true in the .yarnrc as specified by the npm-config. It is treated the same as if the user specifies --ignore-scripts true in the .yarnrc or passes --ignore-scripts as cli arg.

Fixes #6893

Test plan

echo "ignore-scripts true" > .yarnrc

yarn add --pnp webpack-cli@3.2.1
yarn add v1.15.0-0
info No lockfile found.
[1/5] 🔍  Resolving packages...
[2/5] 🚚  Fetching packages...
[3/5] 🔗  Linking dependencies...
warning " > webpack-cli@3.2.1" has unmet peer dependency "webpack@4.x.x".
[5/5] 🔨  Building fresh packages...
warning Ignored scripts due to flag.
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ webpack-cli@3.2.1
info All dependencies
└─ webpack-cli@3.2.1
✨  Done in 1.25s.

ls .pnp
ls: .pnp: No such file or directory

Micha Reiser and others added 3 commits January 30, 2019 16:05
Allow users to specify `ignore-scripts true` in the `.yarnrc` as
specified by the `npm-config`. It is treated the same
as if the user specifies `--ignore-scripts true` in the `.yarnrc` or
passes `--ignore-scripts` as cli arg.
@arcanis
Copy link
Member

arcanis commented Jan 30, 2019

Awesome, thanks! cc @edmorley

@arcanis arcanis merged commit a640f49 into yarnpkg:master Jan 30, 2019
@edmorley
Copy link
Contributor

Thank you! :-)

@MichaReiser MichaReiser deleted the handle-yarnrc-ignore-scripts-consistently branch January 30, 2019 22:20
@MichaReiser
Copy link
Contributor Author

Thanks for allowing me to work on yarn :)

cacheflow added a commit to cacheflow/yarn that referenced this pull request Feb 14, 2019
* master: (67 commits)
  Include key info for "expected hoisted" invariant (yarnpkg#7009)
  refactor: remove unnecessary checks (yarnpkg#6955)
  fix: drive letter casing for win32 pnp (yarnpkg#7007)
  Don’t call `release` with an exit code (yarnpkg#6981)
  Check os and platform even when engines is not present in package.json (yarnpkg#6976)
  Fix handling of non-offline errors (yarnpkg#6968)
  Treat the ignore-scripts in yarnrc as a synonym to the cli arg (yarnpkg#6983)
  fix(pnp): make sure pnp module is again the first preloaded module. (yarnpkg#6951)
  refactor: remove unused imports (yarnpkg#6956)
  Add 1.14.0 to changelog (yarnpkg#6967)
  1.15.0-0
  v1.14.0
  Fix suggested command after unlinking a package (yarnpkg#6931)
  Update CHANGELOG.md
  fix(pnp): make sure pnp module is the first preloaded module. (yarnpkg#6942)
  fix(pnp): make sure that the package locator is fetched with a trailing slash (yarnpkg#6882)
  Improve rendering of Chocolatey package description (yarnpkg#6899)
  Fixing dynamic require missing from webpack (yarnpkg#6908)
  feat(policies): Use github access token when requesting releases (yarnpkg#6912)
  Fixes PnP detection across workspaces (yarnpkg#6878)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants