Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for parsing Yaml files #7300

Merged
merged 5 commits into from May 24, 2019
Merged

Adds support for parsing Yaml files #7300

merged 5 commits into from May 24, 2019

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented May 24, 2019

Summary

This PR adds support for Yarn to read Yaml files. This is needed because now that we switch to Yaml in Berry we need the Yarn v1 branch to parse the v2 .yarnrc files out of the box (in order to make yarn-path work).

Note that the Yaml support here is fickle and purely for reading (emitted files are still using the custom format). In particular, defining a lockfile using the Yaml syntax wouldn't work because the keys are not split on commas.

Ref yarnpkg/berry#183

Test plan

Added a test.

@buildsize
Copy link

buildsize bot commented May 24, 2019

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.11 MB 1.18 MB 67.8 KB (6%)
yarn-[version].js 4.48 MB 4.85 MB 382.69 KB (8%)
yarn-legacy-[version].js 4.67 MB 5.04 MB 382.75 KB (8%)
yarn-v[version].tar.gz 1.12 MB 1.18 MB 67.74 KB (6%)
yarn_[version]all.deb 816.96 KB 868.06 KB 51.11 KB (6%)

@arcanis arcanis merged commit 1089b39 into master May 24, 2019
@arcanis arcanis deleted the js-yaml branch May 24, 2019 06:58
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
* Adds support for parsing Yaml files

* Adds a test

* Removes debug

* Fixes test

* Update CHANGELOG.md
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
* Adds support for parsing Yaml files

* Adds a test

* Removes debug

* Fixes test

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant