fix(E2BIG): Ignore potentially large vscode keys

[eamodio]

Summary

Ignores 2 VS Code extension specific package.json keys that tend to get large and can cause E2BIG errors. I just moved my vscode extension (GitLens) from npm to yarn hoping this issue (a large package.json) wouldn't manifest itself, but sadly it was still an issue.

Here is the original issue I commented on: #5420 (comment)

Fixes #5420 for another instance.

[eamodio]

@BYK I submitted the simple version. Wasn't sure where a warning should really go -- directly here: https://github.com/eamodio/yarn/blob/dfe97900ca5f425d8cf303477b66073f4f6cb812/src/util/execute-lifecycle-script.js#L104?

[BYK]

I think this version is fine since you did not add dropping random stuff based on their sizes. I'll leave the final say to @arcanis.

Btw. I think you need to update some tests or add new ones :)

[eamodio]

Updated with lint fixes -- oops 😄

[buildsize]

File name	Previous Size	New Size	Change
yarn-[version].noarch.rpm	1.18 MB	1.18 MB	12 bytes (0%)
yarn-[version].js	4.85 MB	4.85 MB	244 bytes (0%)
yarn-legacy-[version].js	5.04 MB	5.05 MB	244 bytes (0%)
yarn-v[version].tar.gz	1.18 MB	1.19 MB	1.97 KB (0%)
yarn_[version]all.deb	868.29 KB	868.39 KB	104 bytes (0%)

[eamodio]

@arcanis @BYK Does this looks good? Or do I need to make any other changes?

[BYK]

@eamodio as mentioned before, there should be some updated tests for this change. I'm also waiting for @arcanis to sign off. Guessing he's busy nowadays so will ping him directly.

[arcanis]

Sounds all good to me! ☺️ Can you update the changelog?

[eamodio]

@BYK OK, I figured the existing test was enough, since it enumerates all the keys in that list. What else should I test?

@arcanis Will do.

[BYK]

@BYK OK, I figured the existing test was enough, since it enumerates all the keys in that list. What else should I test?

Hahaha sorry, my bad. I forgot my own refactor making this test future-proof :)

[BYK]

🚀

[eamodio]

Hooray! Thank you!

[eamodio]

@BYK @arcanis any idea of an ETA on the next release of yarn that would include this fix?

[BYK]

@eamodio not sure about the next release but if you need it, you can use the nightly builds safely as a release is just a tagged version of those (and some packaging magic).