Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes link:. #7512

Merged
merged 3 commits into from Sep 1, 2019
Merged

Fixes link:. #7512

merged 3 commits into from Sep 1, 2019

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Sep 1, 2019

Summary

Using link:. currently generates an infinite loop (because we load the dependencies from our own folder, then from our own folder, then from our own folder, then ...).

Test plan

Added such a pattern to the Yarn repo and checked that it works.

@krzysztof-pawlik-gat
Copy link

@arcanis This PR overwrote part of CHANGELOG.md and caused the lint to fail (see two referenced PRs above).

@arcanis
Copy link
Member Author

arcanis commented Sep 9, 2019

@krzysztof-pawlik-gat I removed the entry from the changelog since it was an infra change that wasn't having any effect on the consumers. The lint issue wasn't intended, though.

@krzysztof-pawlik-gat
Copy link

@krzysztof-pawlik-gat I removed the entry from the changelog since it was an infra change that wasn't having any effect on the consumers. The lint issue wasn't intended, though.

Ok, thank you for the explanation, I noticed it only due to unusual merge conflict in the file.

@arcanis arcanis mentioned this pull request Sep 18, 2019
asfernandes referenced this pull request Oct 8, 2019
* Adds a message when people use PnP

* Update en.js
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
* Fixes link:.

* Update CHANGELOG.md
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
* Fixes link:.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants