Preserve linked packages in create command #7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Updated to display |
|
Thanks! 馃檪 |
|
Thanks again for your help! |
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Preserve linked packages in create command * Update changelog * Warn when using linked package * Update CHANGELOG.md * Update link-resolver.js
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Preserve linked packages in create command * Update changelog * Warn when using linked package * Update CHANGELOG.md * Update link-resolver.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
yarn createdoes not respect an existing package linked withyarn link, and will instead overwrite the package in development with the latest version from the registry. With this fix, the package will only be installed if it isn't already linked, allowing users to useyarn createto develop locally linked packages without removing their global link. This matches the functionality ofnpm initandnpm createwith linked packages.Test plan
Fixed test cases
Package is linked
Package is not installed globally and linked聽package is used instead
Unchanged test cases
Package is not linked or installed
Package is installed globally before running the command
Package is installed
Package is reinstalled globally (which may update it) before running the command