Enforces sha512 in the cache #7591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
added a commit
that referenced
this pull request
Oct 8, 2019
* Always store sha512 in the cache * Bumps the cache * Fixes error reporting
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Always store sha512 in the cache * Bumps the cache * Fixes error reporting
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Always store sha512 in the cache * Bumps the cache * Fixes error reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When installing a package through a "low integrity" registry, the sha512 isn't stored. This cause problems when using the same packages with a higher integrity later on, because we won't be able to check the sha512 hash and thus will throw an error.
As a workaround until the v2, we'll simply always compute the sha512 and store it in the cache. It's not the prettiest fix ever, but I don't want to lose days on this.
Test plan
Tested some cases manually. CI will have to do.