Allow dots in bin names

[valerybugakov]

Summary

Bin regex is too restrictive at the moment. See comments here.

Test plan

Use dangerous bin name tests.

[valerybugakov]

@Just-Zach regex has i flag, so it should ignore letter casing?

[BYK]

Colons are not allowed in file names on Windows, so not sure if this is a good idea.

[valerybugakov]

@Just-Zach @BYK from the docs it seems that it should be able to create a symlink using name provided a bin key and colons are not allowed in symlinks too. So it won't validate correctly on Windows.

[arcanis]

Yep colons aren't safe - can you also check against special cases (. and ..)? It'll probably be hard to exploit but eh 🤷‍♀️

[BYK]

As far as I have seen the key is not used as a path - The value would be used as a filepath but it is validated using the isValidBin(...) function. The key is used to reference the value, but isn't used when writing files to disk.

The key is definitely used on the filesystem as that's the name of the created bin/symlink/whatever that is used under nodel_modules/.bin. Now with PnP, maybe we can make that happen in-memory but not sure if that's a worthy investment at this point.

[valerybugakov]

@arcanis multiple dots on windows are allowed
@BYK I'll remove colon from the regex

[saveman71]

Worth noting for future people coming here that yarn cache clean is required to get the missing binaries again (i.e. upgrading and installing/removing nodes_modules isn't enough)