Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new plugin: echo script before execution #7

Open
leaumar opened this issue May 20, 2021 · 5 comments
Open

Merge new plugin: echo script before execution #7

leaumar opened this issue May 20, 2021 · 5 comments

Comments

@leaumar
Copy link
Collaborator

leaumar commented May 20, 2021

A discussion on the yarn repo led to a negative on restoring the yarn v1 (and other PMs) behavior of echoing the commandline of a script before executing it, for a number of reasons. Still wanting a solution for developers who like to know which commands are being run when, I made a plugin that does this, called echo-execute:
image

I have no prior experience working on yarn plugins or publishing nodejs packages, so I have little idea what I'm doing outside the code part of it. I found this project via google and it seems like the place where this kind of plugin could belong. Could we discuss merging my plugin into your project, and its further development (if a 2-liner ever gets any), please?

@koistya
Copy link
Member

koistya commented May 21, 2021

@leaumar you're welcome to add your plugin to the existing yarn-plugins repo or create a new one (similarly to yarn-plugin-deduplicate).

@leaumar
Copy link
Collaborator Author

leaumar commented May 21, 2021

Thanks. What's the team organization like? Do we all work on everything with a collaborated agenda, uniform tools, and peer reviews and such, or do we all manage our own little parts independently like a package repository?
Maybe more to the point, can I just publish my plugin on yarnplugins.com from gitlab or does it need to move to github?

Edit: it seems you maintain a redirection somehow from yarnplugins.com/{id} to direct links to release artifacts for yarn to download. For mine, that would currently be this, linked to release 1. I don't expect to have to make new releases pretty much ever, but gitlab doesn't support a /latest link so it would require a mapping update too.

Edit edit 🙂 ux improvement, release 2, v2 asset

@leaumar
Copy link
Collaborator Author

leaumar commented May 25, 2021

@koistya do you have some guidelines/instructions/prerequisites to get started (that I'll later put in a PR for future readers once I've figured out the process)? I see there's this plugin-push directory with some instructions but it's all a little vague to me without an outline of how yarnplugins.com works, like why is what where and when does it matter.

@koistya
Copy link
Member

koistya commented May 27, 2021

@leaumar yarnplugins.com is a proxy that redirects requests to GitHub (just to make installation experience better). For example:

curl -I https://yarnplugins.com/push
HTTP/2 302
date: Thu, 27 May 2021 09:52:15 GMT
location: https://raw.githubusercontent.com/yarnplugins/yarn-plugins/main/plugin-push/bundles/%40yarnpkg/plugin-push.js

So, if you can move your plugin to GitHub, that would simplify things a bit. If not, it's possible to make an exception for your plugin to redirect to GitLab instead. Feel free to ping me on Discord koistya#2673.

@leaumar
Copy link
Collaborator Author

leaumar commented May 27, 2021

I've sent you a request, username Marnes, same avatar as here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants