Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we kill/reset driver of shared.config each time we change shared.config properties? #453

Open
yashaka opened this issue Oct 9, 2022 · 2 comments

Comments

@yashaka
Copy link
Owner

yashaka commented Oct 9, 2022

should we kill current driver if browser_name is changed? (now it's killed on next driver ask)
or should we open one more? so afterwards the user can switch...
what about making such "mode" also configurable? ;)

consider deprecating changing props like timeout after driver was created
make driver be recreated in such cases
but again... what about making this configurable too? as a "mode"...

@yashaka
Copy link
Owner Author

yashaka commented Oct 9, 2022

    # in the past we forced browser to restart
    # if the config.browser_name was changed to a new version...
    # now we removed this to keep things KISS
    # and potentially less conflict with e.g. Appium...
    # we also checked browser session_id ... why?
    # if stored and \
    #       stored.session_id and \
    #       stored.name == self.browser_name:
    #     return stored

@aleksandr-kotlyar
Copy link
Collaborator

I think we should, yes, cause it's hard to test after changing config a bit without reset. It needs to close driver and open initialize it again now. But! Then should check necessary properties were set up when each change used. It should be clear for users what is default config of shared browser is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants