Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path of screenshot and pagesource on failure – should be windows friendly #519

Closed
yashaka opened this issue Mar 12, 2024 · 2 comments · Fixed by #525
Closed

path of screenshot and pagesource on failure – should be windows friendly #519

yashaka opened this issue Mar 12, 2024 · 2 comments · Fixed by #525
Labels
bug help wanted

Comments

@yashaka
Copy link
Owner

yashaka commented Mar 12, 2024

Currently the rendered in the error message path on Windows – is not clickable, because is rendered incorrectly...
telegram-cloud-photo-size-2-5440527300132198140-y
@yashaka
Copy link
Owner Author

yashaka commented Mar 12, 2024

Here is a place where to start fixing:

selene/selene/core/configuration.py

Line 1237 in 4d7b027

_save_screenshot_strategy: Callable[[Config, Optional[str]], Any] = (

telegram-cloud-photo-size-2-5440361780682545601-y

@cshimm
Copy link
Contributor

cshimm commented Apr 7, 2024

I am working on this.

cshimm added a commit to cshimm/selene that referenced this issue Apr 26, 2024
@cshimm
[yashaka#519] Fix: Format path as URI
bb6805c 
This method allows converting local file paths into clickable URIs. Handles both
Windows and Unix-based paths, ensuring uniform behavior across platforms
cshimm added a commit to cshimm/selene that referenced this issue Apr 26, 2024
@cshimm
[yashaka#519] Fix: Format path as URI
9cd5e22 
This method will format local file paths into clickable URIs. Handles
paths in both Windows and Unix based paths.
@cshimm cshimm mentioned this issue Apr 26, 2024
Merged
yashaka pushed a commit that referenced this issue May 15, 2024
@cshimm
[#519] FIX: Fix path of screenshot and pagesource (#525)
92570f0 
* Update the configuration to log the screenshot and page source file path correctly for all OS types

* prefix variable added. formatted prefix as 'file://'

---------

Co-authored-by: Edale Miguel <edale.miguel@northseattlecolleges.edu>
github-actions bot added a commit that referenced this issue May 15, 2024
@github-actions
[#519] FIX: Fix path of screenshot and pagesource (#525)
9085f38 
* Update the configuration to log the screenshot and page source file path correctly for all OS types

* prefix variable added. formatted prefix as 'file://'

---------

Co-authored-by: Edale Miguel <edale.miguel@northseattlecolleges.edu>
yashaka added a commit that referenced this issue May 15, 2024
@yashaka
[#519] DOCS: update changelog
2ad51e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#519] FIX: Fix path of screenshot and pagesource cshimm/selene
2 participants
@yashaka @cshimm