Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstantUsageCheck error message is misleading #260

Closed
carlosmiranda opened this issue May 27, 2014 · 9 comments
Closed

ConstantUsageCheck error message is misleading #260

carlosmiranda opened this issue May 27, 2014 · 9 comments
Labels

Comments

@carlosmiranda
Copy link
Contributor

ConstantUsageCheck has the following message if it detects a violation:

String.format("Constant \"%s\" used only once", name);

It's misleading. ConstantUsageCheck actually enforces that a private field be used at least twice, so it'll also be triggered for unused constants. Let's re-word it to reflect this behavior or otherwise show an alternative message for unused constants.

@carlosmiranda carlosmiranda changed the title ConstantUsageCheck error is misleading ConstantUsageCheck error message is misleading May 27, 2014
@davvd
Copy link

davvd commented May 27, 2014

I'll ask someone to take care of this task soon

@davvd
Copy link

davvd commented May 28, 2014

@carlosmiranda thanks for reporting! I topped your account for 15 mins, transaction 40144614

@davvd
Copy link

davvd commented Aug 20, 2014

@krzyk the issue is yours, please help

@davvd davvd added the @krzyk label Aug 20, 2014
krzyk pushed a commit to krzyk/qulice that referenced this issue Aug 21, 2014
@krzyk
Copy link
Collaborator

krzyk commented Aug 21, 2014

@carlosmiranda Fix has been merged, please close this issue.

@carlosmiranda
Copy link
Contributor Author

@krzyk Looks good, thanks!

@krzyk
Copy link
Collaborator

krzyk commented Aug 27, 2014

@davvd ping

@davvd
Copy link

davvd commented Aug 31, 2014

@krzyk thanks, I just added 15 mins to your account, payment 43893332

@davvd
Copy link

davvd commented Nov 24, 2014

these 2 puzzles were created in this ticket: 260-dc51e6f4, 260-1576b183

@0pdd
Copy link
Collaborator

0pdd commented Aug 3, 2022

@carlosmiranda the puzzle #1124 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants