Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavadocTagsCheck false positive for valid email #412

Closed
longtimeago opened this issue Mar 4, 2015 · 19 comments
Closed

JavadocTagsCheck false positive for valid email #412

longtimeago opened this issue Mar 4, 2015 · 19 comments
Assignees
Labels

Comments

@longtimeago
Copy link
Contributor

Here is the javadoc

/**
 * Tests for {@link com.sigzig.ui.ToggleLogButton}.
 *
 * @author Gerrit (han.solo@xmpp.mobilezoo.org)
 * @version $Id$
 */

It produces following error:

Tag text 'Gerrit (han.solo@xmpp.mobilezoo.org)' does not match the pattern 
'^([A-Z](\.|[a-z]+) ){2,}\([A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}\)$' (JavadocTagsCheck)

Which is definitely wrong.


@longtimeago longtimeago changed the title JavadocTagsCheck false positive for email JavadocTagsCheck false positive for valid email Mar 4, 2015
@davvd
Copy link

davvd commented Jun 15, 2015

@yegor256 please dispatch this issue

@yegor256 yegor256 added the bug label Jul 13, 2015
@davvd
Copy link

davvd commented Jul 14, 2015

@longtimeago many thanks, 15 mins added to your acc for reporting this bug, pmt ID 61136399

@davvd davvd added DEV labels Jul 14, 2015
@krzyk krzyk mentioned this issue Oct 29, 2015
@krzyk
Copy link
Collaborator

krzyk commented Nov 9, 2015

@davvd this is postponed

@davvd
Copy link

davvd commented Nov 13, 2015

@davvd this is postponed

@krzyk right, I added "postponed" label

@davvd
Copy link

davvd commented Nov 13, 2015

@davvd this is postponed

@krzyk no problem, I will try to find somebody else

@krzyk
Copy link
Collaborator

krzyk commented Nov 16, 2015

@davvd this is not postponed

@krzyk
Copy link
Collaborator

krzyk commented Nov 16, 2015

@davvd assign @krzyk here

@krzyk
Copy link
Collaborator

krzyk commented Nov 16, 2015

@longtimeago the above fails because we expect at a person to have at least first and last name. It will work if you give Gerrit a second name.
E.g. the following passes check:

/**
 * Tests for {@link com.sigzig.ui.ToggleLogButton}.
 *
 * @author John Gerrit (han.solo@xmpp.mobilezoo.org)
 * @version $Id$
 */

Should we expect to have people with only single name (first or last)?

@longtimeago
Copy link
Contributor Author

@krzyk I think it's too stict to expect both

@longtimeago
Copy link
Contributor Author

@krzyk one may want to put a nick instead of real name

@krzyk
Copy link
Collaborator

krzyk commented Nov 16, 2015

@davvd please see PR #496

@davvd
Copy link

davvd commented Nov 17, 2015

@davvd this is not postponed

@krzyk got it, "postponed" tag removed from here

@davvd davvd removed the postponed label Nov 17, 2015
@davvd
Copy link

davvd commented Nov 17, 2015

@davvd assign @krzyk here

@krzyk OK @krzyk please go ahead, this task is yours

@davvd
Copy link

davvd commented Nov 17, 2015

@davvd please see PR #496

@krzyk thank you, I will check it

krzyk added a commit to krzyk/qulice that referenced this issue Nov 18, 2015
krzyk added a commit to krzyk/qulice that referenced this issue Nov 18, 2015
@krzyk
Copy link
Collaborator

krzyk commented Nov 26, 2015

@longtimeago code has been updated in master, please close this issue

@longtimeago
Copy link
Contributor Author

@krzyk thank you!

@davvd
Copy link

davvd commented Nov 30, 2015

@krzyk Much obliged! I have added 30 mins to your account in payment "70771021", 237 hours and 37 mins spent

+30 added to your rating, at the moment it is: +2853

@davvd
Copy link

davvd commented Nov 30, 2015

@longtimeago once 412-bd044e76/#505 puzzle is resolved (later, in another ticket), this ticket will be fully complete

@0pdd
Copy link
Collaborator

0pdd commented Aug 3, 2022

@longtimeago the puzzle #1125 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants