Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .rultor.yml from a PR instead of getting it from a default branch #1668

Open
volodya-lombrozo opened this issue Mar 29, 2023 · 2 comments

Comments

@volodya-lombrozo
Copy link
Contributor

No so long time ago we faced with the problem of updating .rultor.yml. The problem is that we can not update .rultor.yml by using default development approach - through PR`s:

this particular commit rultor wouldn't catch, because it uses .rultor.yml from master. I don't push to master, but this one was the only possible option

objectionary/eo#1949 (comment)

This is quite risky: even rare direct pushes to a default branch can break all CI pipelines and break development process.


I'm aware about that problem, but since it doesn't explain possible threats, I don't see vulnerabilities in that approach.

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you have a look, please? What do you think?

@yegor256
Copy link
Owner

@volodya-lombrozo take a look: #1039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants