Skip to content

Latest commit

 

History

History
15 lines (12 loc) · 1.03 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

15 lines (12 loc) · 1.03 KB
Raw

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems, or leave puzzles)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed
  • Title begins with the issue's number, then a short title
  • Description begins with the issue's number, then enumerates the changes - summarized - in bulletpoints
  • Description does not contain GitHub keywords (https://help.github.com/articles/closing-issues-using-keywords/).
  • You ran the build locally and it passed (see .travis.yml for all checks performed on PRs)

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!