Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CcAes doesn't throw the right exception #814

Closed
yegor256 opened this issue Mar 1, 2018 · 13 comments
Closed

CcAes doesn't throw the right exception #814

yegor256 opened this issue Mar 1, 2018 · 13 comments
Assignees

Comments

@yegor256
Copy link
Owner

yegor256 commented Mar 1, 2018

java.lang.IllegalStateException: [GET http://www.0crat.com/u/yegor256] failed in 0ms: javax.crypto.IllegalBlockSizeException: Input length must be multiple of 16 when decrypting with padded cipher
	at org.takes.facets.fallback.TkFallback.error(TkFallback.java:234)
	at org.takes.facets.fallback.TkFallback.route(TkFallback.java:115)
	at org.takes.facets.fallback.TkFallback.access$000(TkFallback.java:54)
	at org.takes.facets.fallback.TkFallback$1.act(TkFallback.java:66)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at com.zerocracy.tk.TkSslOnly.act(TkSslOnly.java:59)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at org.takes.http.BkBasic.print(BkBasic.java:108)
	at org.takes.http.BkBasic.accept(BkBasic.java:84)
	at org.takes.http.BkSafe$1.accept(BkSafe.java:51)
	at org.takes.http.BkWrap.accept(BkWrap.java:52)
	at org.takes.http.BkTimeable.accept(BkTimeable.java:89)
	at org.takes.http.BkParallel$1$1.run(BkParallel.java:89)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: javax.crypto.IllegalBlockSizeException: Input length must be multiple of 16 when decrypting with padded cipher
	at org.takes.facets.auth.codecs.CcAes.decrypt(CcAes.java:165)
	at org.takes.facets.auth.codecs.CcAes.decode(CcAes.java:102)
	at org.takes.facets.auth.codecs.CcHex.decode(CcHex.java:117)
	at org.takes.facets.auth.codecs.CcSafe.decode(CcSafe.java:64)
	at com.zerocracy.tk.CcSecure.decode(CcSecure.java:77)
	at org.takes.facets.auth.PsCookie.enter(PsCookie.java:105)
	at org.takes.facets.auth.PsChain.enter(PsChain.java:70)
	at org.takes.facets.auth.TkAuth.act(TkAuth.java:86)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at org.takes.facets.flash.TkFlash.act(TkFlash.java:108)
	at org.takes.tk.TkGzip$1.act(TkGzip.java:58)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at org.takes.tk.TkMeasured$1.act(TkMeasured.java:67)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at org.takes.tk.TkVersioned$1.act(TkVersioned.java:73)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at org.takes.tk.TkWithHeaders$1.act(TkWithHeaders.java:71)
	at org.takes.tk.TkWrap.act(TkWrap.java:61)
	at org.takes.facets.fallback.TkFallback.route(TkFallback.java:86)
	... 14 more
Caused by: javax.crypto.IllegalBlockSizeException: Input length must be multiple of 16 when decrypting with padded cipher
	at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:936)
	at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:847)
	at com.sun.crypto.provider.AESCipher.engineDoFinal(AESCipher.java:446)
	at javax.crypto.Cipher.doFinal(Cipher.java:2165)
	at org.takes.facets.auth.codecs.CcAes.decrypt(CcAes.java:161)
	... 32 more
@yegor256 yegor256 self-assigned this Mar 1, 2018
@0crat 0crat added the scope label Mar 1, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 1, 2018

The job #814 assigned to @yegor256/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@yegor256
Copy link
Owner Author

yegor256 commented Mar 1, 2018

@rultor release, tag is 1.8.2

yegor256 added a commit that referenced this issue Mar 1, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 1, 2018

Bug was reported, see §29: +15 points just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Mar 1, 2018

Manual assignment of issues is discouraged, see §19: -5 points just awarded to @yegor256/z

@rultor
Copy link
Collaborator

rultor commented Mar 1, 2018

@rultor release, tag is 1.8.2

@yegor256 OK, I will release it now. Please check the progress here

@0crat
Copy link
Collaborator

0crat commented Mar 1, 2018

It is strongly discouraged to assign jobs to their creators, see §19: -15 points just awarded to @yegor256/z

@rultor
Copy link
Collaborator

rultor commented Mar 1, 2018

@rultor release, tag is 1.8.2

@yegor256 Done! FYI, the full log is here (took me 13min)

@yegor256 yegor256 closed this as completed Mar 1, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 1, 2018

@elenavolokhova/z please review this job, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@elenavolokhova
Copy link

@yegor256 According to QA Rules:

Problem reporter and problem solver are two different persons

In this ticket you were the reporter and solver.

Some of ticket messages must mention all pull requests where the problem was actually fixed.

There was no PR created for this issue, so the link is not included.

Please, try to avoid such issues in future.

@elenavolokhova
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Mar 2, 2018

QA review completed: +8 points just awarded to @elenavolokhova/z

@0crat 0crat removed the scope label Mar 2, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 2, 2018

Order was finished, quality was "acceptable": +30 points just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Mar 2, 2018

@0crat quality acceptable (here)

@elenavolokhova The job #814 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants