Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:373-377: Upgrade qulice to latest 0.17.x and if... #880

Closed
0pdd opened this issue Dec 1, 2018 · 20 comments
Closed

pom.xml:373-377: Upgrade qulice to latest 0.17.x and if... #880

0pdd opened this issue Dec 1, 2018 · 20 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 1, 2018

The puzzle 837-241b1372 from #837 has to be resolved:

takes/pom.xml

Lines 373 to 377 in c8f3ef2

@todo #837:30min Upgrade qulice to latest 0.17.x and if possible
to latest 0.18.x and fix all the issues it detects for the build
to pass. In 0.17.6, some changes impact a lot of file, while in
0.18 there should be less new issues. Don't forget about the IT
test ran by maven-invoker-plugin.

The puzzle was created by Victor Noël on 28-Nov-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Dec 1, 2018

@paulodamaso/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Dec 1, 2018

Job #880 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Dec 2, 2018

The job #880 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@victornoel
Copy link
Contributor

@0crat wait for yegor256/qulice#953 to be fixed

@0crat
Copy link
Collaborator

0crat commented Dec 2, 2018

@0crat wait for yegor256/qulice#953 to be fixed (here)

@victornoel The impediment for #880 was registered successfully by @victornoel/z

@paulodamaso
Copy link
Contributor

@victornoel You can exceptionally set checkstyle @checkstyle <check> (n lines) annotation to ignore some check in the next lines, so you should set this if you want to get your ticket moving before yegor256/qulice#953 is fixed.

@victornoel
Copy link
Contributor

@paulodamaso good point, I completely forgot about that :) thanks!

victornoel added a commit to victornoel/takes that referenced this issue Dec 8, 2018
@victornoel
Copy link
Contributor

@paulodamaso the PR is #886, yegor256/qulice#953 was fixed :)

victornoel added a commit to victornoel/takes that referenced this issue Dec 11, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 11, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 11, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 11, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 11, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 11, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 12, 2018
victornoel added a commit to victornoel/takes that referenced this issue Dec 12, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 12, 2018

The puzzle 837-241b1372 has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Collaborator Author

0pdd commented Dec 12, 2018

@0pdd the puzzle #894 is still not solved.

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

@ypshenychka/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Dec 12, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

The job #880 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 11, 2022

@0pdd the puzzle #1128 is still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 11, 2022

@0pdd the puzzle #unknown is still not solved; solved: #1128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants