From 30407046540506415b5b94bfde07a1ccef906df8 Mon Sep 17 00:00:00 2001 From: volodya-lombrozo Date: Wed, 15 Nov 2023 17:33:03 +0300 Subject: [PATCH] feat(#64): fix all qulice suggestions --- src/main/java/org/xembly/Output.java | 10 ++++------ src/main/java/org/xembly/Xembler.java | 5 +++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/xembly/Output.java b/src/main/java/org/xembly/Output.java index 025fa89..31c57ad 100644 --- a/src/main/java/org/xembly/Output.java +++ b/src/main/java/org/xembly/Output.java @@ -41,13 +41,12 @@ */ public interface Output { - /** * Prepare transformer before using it. * @param transformer Transformer to prepare. * @since 0.30 */ - void prepare(final Transformer transformer); + void prepare(Transformer transformer); /** * Document output. @@ -67,7 +66,7 @@ final class Document implements Output { * @since 0.30 */ public Document() { - this((Document.defaultProperties())); + this(Document.defaultProperties()); } /** @@ -81,8 +80,7 @@ public Document(final Map properties) { @Override public void prepare(final Transformer transformer) { - this.properties.entrySet().stream() - .forEach((e) -> transformer.setOutputProperty(e.getKey(), e.getValue())); + this.properties.forEach(transformer::setOutputProperty); } /** @@ -90,7 +88,7 @@ public void prepare(final Transformer transformer) { * @return Properties to configure the output. */ private static Map defaultProperties() { - final HashMap res = new HashMap<>(); + final Map res = new HashMap<>(); res.put(OutputKeys.INDENT, "yes"); res.put(OutputKeys.ENCODING, "UTF-8"); return res; diff --git a/src/main/java/org/xembly/Xembler.java b/src/main/java/org/xembly/Xembler.java index ff9f47f..2c17671 100644 --- a/src/main/java/org/xembly/Xembler.java +++ b/src/main/java/org/xembly/Xembler.java @@ -100,6 +100,9 @@ public final class Xembler { */ private final Iterable directives; + /** + * Output type. + */ private final Output output; static { @@ -259,8 +262,6 @@ public String xml() throws ImpossibleModificationException { ); } this.output.prepare(transformer); -// transformer.setOutputProperty(OutputKeys.INDENT, "yes"); -// transformer.setOutputProperty(OutputKeys.ENCODING, "UTF-8"); final StringWriter writer = new StringWriter(); try { transformer.transform(