Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directives.set() now accept CharSequence #93

Closed
wants to merge 1 commit into from
Closed

Directives.set() now accept CharSequence #93

wants to merge 1 commit into from

Conversation

xaircore
Copy link

Close #55

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@0crat
Copy link
Collaborator

0crat commented Sep 24, 2019

@carlosmiranda/z please, pay attention to this pull request

@0crat
Copy link
Collaborator

0crat commented Sep 24, 2019

@xaircore/z this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @carlosmiranda/z please review this and merge or reject

@0crat
Copy link
Collaborator

0crat commented Sep 25, 2019

Job gh:yegor256/xembly#93 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Sep 25, 2019

This job is not in scope

@xaircore xaircore deleted the feature/derictives_set_char_sequence branch September 25, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directives.set() should accept CharSequence
3 participants