Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check.js: Please don't run checkNpm when disabled is true #169

Open
KernelLeak opened this issue Aug 30, 2019 · 0 comments
Open

check.js: Please don't run checkNpm when disabled is true #169

KernelLeak opened this issue Aug 30, 2019 · 0 comments

Comments

@KernelLeak
Copy link

I was tearing my hair out why building a node.js app in Visual Studio 2019 was taking ages, and it turns out there was a node.js process running check.js that was hanging; killing it was making VS immediately finish it's build.

Long story short - I tried setting NO_UPDATE_NOTIFIER because I'm behind a corporate firewall and something was making direct requests to the repository, but it turns out it was package-json which is used indirectly in checkNpm (via latest-version); proxy support for package-json was shot down by it's maintainer, see the comedy that is sindresorhus/package-json#54 .

So even with NO_UPDATE_NOTIFIER set the check.js included with npm 6.10.2 included with the current node 12.9.1 out of the box hangs for a long time trying to access the registry when you're behind a proxy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant