New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method for directly checking for an update #85
Comments
It's in the options as it's not the main way to use this module. Ideally, it would support promises too. I think that would be a better change. |
Actually, I think we should just deprecate the |
@IssueHunt has funded $40.00 to this issue.
|
I have already solved this issue in the #151. |
We can use the |
I will make a new pull request to deprecate the |
Fixed by #158 |
@sindresorhus has rewarded $36.00 to @litomore. See it on IssueHunt
|
Having the
callback
specified as a field in the options object makes this library incompatible with e.g.pify
and I think all other promisify-libraries as well. It's also very uncommon in the Node.js community where the callback is usually given as the last parameter.Would it be possible to update to a form where the callback is given as a second parameter? This could probably be done in a backwards compatible way as well. Possibly printing deprecation warning and then dropping it in the next major version.
Any thoughts?
IssueHunt Summary
litomore has been rewarded.
Backers (Total: $40.00)
Submitted pull Requests
callback
optionTips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: