From 6665f487336df8755e1846752b7baf9e2c5bb47b Mon Sep 17 00:00:00 2001 From: Martin Molzer Date: Sun, 19 Jun 2022 16:48:11 +0200 Subject: [PATCH] address review --- packages/yew-macro/src/derive_props/field.rs | 4 ++-- packages/yew/src/html/component/properties.rs | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/yew-macro/src/derive_props/field.rs b/packages/yew-macro/src/derive_props/field.rs index 53c1309828f..657b503e475 100644 --- a/packages/yew-macro/src/derive_props/field.rs +++ b/packages/yew-macro/src/derive_props/field.rs @@ -39,12 +39,12 @@ impl PropField { /// This check name is descriptive to help a developer realize they missed a required prop fn to_check_name(&self, props_name: &Ident) -> Ident { - format_ident!("Has{}{}", props_name, self.name, span = Span::mixed_site(),) + format_ident!("Has{}{}", props_name, self.name, span = Span::mixed_site()) } /// This check name is descriptive to help a developer realize they missed a required prop fn to_check_arg_name(&self, props_name: &Ident) -> GenericParam { - let ident = format_ident!("How{}{}", props_name, self.name, span = Span::mixed_site(),); + let ident = format_ident!("How{}{}", props_name, self.name, span = Span::mixed_site()); GenericParam::Type(ident.into()) } diff --git a/packages/yew/src/html/component/properties.rs b/packages/yew/src/html/component/properties.rs index d4cf68658d9..344f6509c26 100644 --- a/packages/yew/src/html/component/properties.rs +++ b/packages/yew/src/html/component/properties.rs @@ -11,7 +11,8 @@ pub trait Properties: PartialEq { fn builder() -> Self::Builder; } -mod macro_export { +#[doc(hidden)] +mod __macro { /// A marker trait to ensure that the builder has received a specific required prop. /// For each required impl in a property, we generate: /// - a struct with the name of the prop, which takes the place of `P`. @@ -29,6 +30,8 @@ mod macro_export { /// A marker trait to ensure that the builder has received all required props. /// For each struct deriving [`Properties`], an impl is generated, requiring `HasProp

` for /// all properties marked as required as a bound on the impl. + /// + /// [`Properties`]: super::Properties pub trait HasAllProps {} /// Trait finishing the builder and verifying all props were set. @@ -113,4 +116,4 @@ mod macro_export { } #[doc(hidden)] -pub use macro_export::{AllPropsFor, AssertAllProps, Buildable, HasAllProps, HasProp}; +pub use __macro::{AllPropsFor, AssertAllProps, Buildable, HasAllProps, HasProp};