Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldSwipeOnMouse block onTap handler #78

Open
Ruslan27032000 opened this issue Aug 25, 2022 · 3 comments
Open

shouldSwipeOnMouse block onTap handler #78

Ruslan27032000 opened this issue Aug 25, 2022 · 3 comments
Assignees
Labels
bug Something isn't working cannot replicate We can't replicate the issue

Comments

@Ruslan27032000
Copy link

When you add prop shouldSwipeOnMouse you cannot maximize slide

To Reproduce
Steps to reproduce the behavior:

  1. Add shouldSwipeOnMouse to gallery
  2. Click on image
  3. See error

Expected behavior
Maximize image

Additional context
I already fixed it by adding
image
image
but I don't know how to test it

@yifaneye
Copy link
Owner

yifaneye commented Sep 4, 2022

Hi @Ruslan27032000 , thanks for raising this issue up!

Thank you for your time and work. I do not have a lot of existing tests. Could you please create a pull request? I will review the pull request and test the functionalities.

@yifaneye yifaneye self-assigned this Sep 4, 2022
@yifaneye yifaneye added the bug Something isn't working label Sep 4, 2022
@yifaneye yifaneye added this to To do in react-gallery-carousel via automation Sep 4, 2022
@yifaneye
Copy link
Owner

Hi @Ruslan27032000 !

Could you please create a pull request to merge into the master branch?

@yifaneye
Copy link
Owner

Hi @Ruslan27032000 ! I can't reproduce your bugs. Can you give me more information?

@yifaneye yifaneye added the cannot replicate We can't replicate the issue label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cannot replicate We can't replicate the issue
Development

No branches or pull requests

2 participants