Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show the first image #89

Open
moham96 opened this issue May 11, 2023 · 4 comments
Open

Only show the first image #89

moham96 opened this issue May 11, 2023 · 4 comments
Assignees
@yifaneye
Labels
bug Something isn't working good first issue Good for newcomers
Projects
react-gallery-carousel

Comments

@moham96
Copy link

moham96 commented May 11, 2023

Describe the bug
Only the first image is rendered, if I select another image it will just show a black background, thumbnails are rendered below correctly but when selecting any image other than the first it shows as black background

To Reproduce
Steps to reproduce the behavior:
1- run the example code in the "Usage" section of the readme
2- select a slide other than the first one, you will see a black screen

Expected behavior
All slides should render correctly

Screenshots
Screenshot 2023-05-11 at 1 56 51 PM

Desktop (please complete the following information):

  • OS: Macos
  • Browser :Firefox
  • Version 113

Smartphone (please complete the following information):
Not tested

Additional context
N/A
@moham96
Copy link
Author

moham96 commented May 11, 2023

update: This only happens if the html tag of the page has dir="rtl"

@yifaneye
Copy link
Owner

Hi @moham96 ! Thanks for raising this issue!

I can replicate this issue. I didn't know the use of <html > dir="rtl". I am sorry for the inconvenience! I think I need to change this line. I will keep you updated.

@yifaneye yifaneye self-assigned this May 17, 2023
@yifaneye yifaneye added bug Something isn't working good first issue Good for newcomers labels May 17, 2023
@yifaneye yifaneye added this to To do in react-gallery-carousel via automation May 17, 2023
@moham96
Copy link
Author

moham96 commented May 17, 2023

Current workaround is to force ltr just for the carousel element by wrapping the carousel component with

<div dir="ltr">
 <ReactGalleryCarousel></ReactGalleryCarousel>
</div>

@yifaneye
Copy link
Owner

Okay. Thanks for sharing! I will try to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yifaneye yifaneye

Labels
bug Something isn't working good first issue Good for newcomers
Projects
react-gallery-carousel
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moham96 @yifaneye