Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveQuery class should not extend Yiisoft\Db\Query\Query #281

Open
Tigrov opened this issue Dec 24, 2023 · 1 comment
Open

ActiveQuery class should not extend Yiisoft\Db\Query\Query #281

Tigrov opened this issue Dec 24, 2023 · 1 comment
Labels
type:enhancement Enhancement

Comments

@Tigrov
Copy link
Member

Tigrov commented Dec 24, 2023 •
edited

Yiisoft\Db\Query\Query class can be extended in each supported DBMS.

E.g. we can have Yiisoft\Db\Mssql\Query which extends Yiisoft\Db\Query\Query.

In this case ActiveQuery will not know about the extensions in Yiisoft\Db\Mssql\Query.

Suggestion

Connection of DBMS should return concrete Query instance to use it in ActiveQuery.
@samdark samdark added the type:enhancement Enhancement label Dec 24, 2023
@samdark
Copy link
Member

samdark commented Dec 24, 2023

Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @Tigrov