Summary for ActiveRecord

[Tigrov]

• 1. Rename BaseActiveRecord class to AbstractActiveRecord
• 2. Make AbstractActiveRecord class implements only ActiveRecordInterface
• 3. Move other interfaces to ActiveRecord class
• 4. Move implementation of the interfaces to traits
• 5. Move $properties with magic methods __get(), __set(), __isset(), __unset() to MagicPropertiesTrait and use it in ActiveRecord class
• 6. Access to properties values inside AbstractActiveRecord via $this->$name only
• 7. To get a relation query instance of ActiveQueryInterface use method with prefix get and suffix Query, e.g. getOrderQuery(): ActiveQueryInterface instead of getOrder(): ActiveQueryInterface
• 8. To get a relation value use method with prefix get, e.g. getOrder(): ActiveRecordInterface|null
• 9. Rename method getRelation(): ActiveQueryInterface to relationQuery(): ActiveQueryInterface
• 10. Add method to get a value of relation relation(string $name): ActiveRecordInterface|null {return $this->related[$name] ?? null;}
• 11. Split magical and non-magical implementations
• 12. Test traits and concrete implementations separately
• 13. Update documentation

[xepozz]

Great ideas, especially with naming for relations. I have a question:
What's the reason to rename attributes to properties?

[Tigrov]

What's the reason to rename attributes to properties?

It was discussed that there is confusion between the $attributes AR property and PHP's #[Attribute].

But it's a good question. Now this looks doubtful due to major changes and needs to be discussed again. Due to the renaming of public methods whose names contain attribute.

[vjik]

But it's a good question. Now this looks doubtful due to major changes and needs to be discussed again. Due to the renaming of public methods whose names contain attribute.

Are there any pitfalls here? Rename methods also it looks logically.

[Tigrov]

Are there any pitfalls here? Rename methods also it looks logically.

Discussion about renaming $attributes moved to #343