New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix equalDeleteSets #548

Merged

dmonad merged 2 commits into yjs:main from YousefED:fix/equalDeleteSets

Jun 22, 2023

Contributor

YousefED commented Jun 21, 2023 •

edited by huly-github bot

equalDeleteSets didn't work properly, because the return false in the foreach only quits a "single foreach", not the entire function

_{Huly®: YJS-472}

YousefED added 2 commits

June 21, 2023 18:28


          fix equalDeleteSets

12be6c0


          keep original imports

eda0859

Member

dmonad commented Jun 22, 2023

oh my .. thanks @YousefED !

equalDeleteSets didn't work properly, because the return false in the foreach only quits a "single foreach", not the entire function

dmonad merged commit 83b7c68 into yjs:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment