Only emit "load" when sync is set to true #587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when we use
doc.emit('sync', [false])
, at the moment, it'll emitload
and changeisLoaded
totrue
.In our case, we call
doc.emit('sync', [false])
when our socket connection is dropped; and sometimes it can happen before the first time we calleddoc.emit('sync', [true])
.The alternative to this PR is to change the logic of the
sync
event to not accept an argument and to behave like theload
event where calling it always set the state to true.The workaround at the moment is to make sure to wrap
doc.emit('sync', [false])
withif (doc.isSynced) { }
.