Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the version config setup for the project #306

Open
chenrui333 opened this issue Dec 11, 2022 · 3 comments
Open

About the version config setup for the project #306

chenrui333 opened this issue Dec 11, 2022 · 3 comments
Assignees
Labels
good first issue Good for newcomers question Further information is requested

Comments

@chenrui333
Copy link

While trying to include this tool into homebrew-core, I saw the version config is actually weird for the project. Why not just use one config rather than two?

Like merge -X github.com/yoheimuta/protolint/internal/cmd/protocgenprotolint.version into -X github.com/yoheimuta/protolint/internal/cmd.version. Thanks!

@yoheimuta
Copy link
Owner

@chenrui333 Thank you for including this tool into homebrew-core! Sounds great.
I'm checking it out soon.

@yoheimuta yoheimuta self-assigned this Dec 29, 2022
@yoheimuta yoheimuta added the question Further information is requested label Dec 29, 2022
@yoheimuta
Copy link
Owner

@chenrui333 I refreshed my memory.
I just had no motivation to merge the existing cmd.go, when I added protoc-gen-protolint to this project later.

So, you have a point and it's a good first issue 👍

@yoheimuta yoheimuta added the good first issue Good for newcomers label Dec 29, 2022
@chenrui333
Copy link
Author

We are aligned, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants