Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The spec yaml files in this repo fail lots of Swagger validations #296

Open
rogerluan opened this issue Jan 13, 2022 · 0 comments
Open

The spec yaml files in this repo fail lots of Swagger validations #296

rogerluan opened this issue Jan 13, 2022 · 0 comments

Comments

@rogerluan
Copy link

Description

If we pass /Specs/PetstoreTest/spec.yml through the online validator a https://editor.swagger.io, it throws these validation errors:

image

Same goes for /Specs/Rocket/spec.yml (there're tens of errors on this one, they wouldn't all fit in a single screenshot):

image

And /Specs/TBX/spec.json:

image

And /Specs/TestSpec/spec.yml:

image

And /Specs/TFL/spec.json:

image

Room for Improvement

I think a great improvement would be to have a spec validation step in CI for this repo, so that on every PR we'd be checking if all the spec yaml files continue to be valid. Here's a reference: https://swagger.io/blog/api-design/validate-openapi-definitions-swagger-editor/

@rogerluan rogerluan changed the title Spec yaml files fail lots of Swagger validations The spec yaml files in this repo fail lots of Swagger validations Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant