Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script error when accessing a document created by ProseMirror example on dashboard #130

Open
hackerwins opened this issue Jun 28, 2023 · 4 comments
Labels
bug 🐞 Something isn't working good first issue 🐤 Good for newcomers

Comments

@hackerwins
Copy link
Member

Description:

Script error when accessing a document created by ProseMirror example on dashboard

After creating the document of the ProseMirror example of the JS SDK, there seems to be a script error occurring when accessing the document on the Dashboard.

In the example, the selection is saved as a byte array type in the document to propagate it to the peers.

Screenshot 2023-06-28 at 2 07 44 PM

However, this seems to be causing a script error when performing JSON.parse on the Dashboard.

Why:

@hackerwins hackerwins added bug 🐞 Something isn't working good first issue 🐤 Good for newcomers labels Jun 28, 2023
@DongjaJ
Copy link
Contributor

DongjaJ commented Jul 26, 2023

can I try this?

@hackerwins
Copy link
Member Author

@DongjaJ Sure.

The error occurs when assigning a byte array(Uint8Array) to a document.

https://github.com/yorkie-team/yorkie-js-sdk/blob/c12ef2583ad0f85c4774eea30f8451a93262f0d3/test/integration/primitive_test.ts#L58-L68

@DongjaJ
Copy link
Contributor

DongjaJ commented Jul 29, 2023

I found the following error in the process of re-creating this issue.

  1. create the document of the ProseMirror example of the JS SDK
  2. access the document on the Dashboard
  3. click another tab (ex. Project overview, api, setting...)

And I could not recreate Error on this issue
에러 재생산 중 발생한 이슈

@hackerwins
Copy link
Member Author

We have stabilized yorkie.Tree until the v0.4.7 release. For now, the error described in this issue does not recur for now.

For #130 (comment):
I have confirmed that the issue described in the comment still occurs in development mode. This is only happening in the development environment, so I guess it is related to the development mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working good first issue 🐤 Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants