Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] migration moment.js to date-fns #140

Open
DongjaJ opened this issue Apr 11, 2024 · 2 comments
Open

[suggestion] migration moment.js to date-fns #140

DongjaJ opened this issue Apr 11, 2024 · 2 comments
Labels
cleanup 🧹 Paying off technical debt good first issue 🐤 Good for newcomers

Comments

@DongjaJ
Copy link
Contributor

DongjaJ commented Apr 11, 2024

Description:
migration moment.js to date-fns

Why:
Moment is lagacy project. And it might cause a huge performance overhead because of its complex APIs and large bundle size.

moment docs
You-Dont-Need-Momentjs
@hackerwins
Copy link
Member

Thank you for your good comments.
Could you send a PR for this?

@DongjaJ
Copy link
Contributor Author

DongjaJ commented Apr 11, 2024

Sure! I'll try this

@hackerwins hackerwins added good first issue 🐤 Good for newcomers cleanup 🧹 Paying off technical debt labels Apr 11, 2024
@DongjaJ DongjaJ mentioned this issue Apr 13, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Paying off technical debt good first issue 🐤 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: migrate moment to date-fns DongjaJ/dashboard
2 participants
@hackerwins @DongjaJ