Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate moment to date-fns #141

Closed

Conversation

DongjaJ
Copy link
Contributor

@DongjaJ DongjaJ commented Apr 13, 2024

What this PR does / why we need it?

Moment is a lagacy project. And it might cause a huge performance overhead because of its complex APIs and large bundle size. So this PR migrations moment.js to date-fns

Any background context you want to provide?

What are the relevant tickets?

Fixes #140

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for introducing date-fns.
I left a few comments.

src/features/documents/DocumentList.tsx Outdated Show resolved Hide resolved
@DongjaJ DongjaJ requested a review from hackerwins April 16, 2024 01:13
@hackerwins
Copy link
Member

Thanks for your contribution.
This was merged by caae354.

@hackerwins hackerwins closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] migration moment.js to date-fns
3 participants