Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing animation for pen cursor isn't smooth for displaying remote cursors. #612

Open
YoonKiJin opened this issue Aug 10, 2023 · 2 comments
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers

Comments

@YoonKiJin
Copy link
Contributor

YoonKiJin commented Aug 10, 2023

Description:

The Simultaneous Cursors example uses two kinds of animations. One is an emoji "bubbling" animation for the Heart and Thumbs cursors, while the other is a "drawing" animation for the Pen cursor. For the drawing animation, the drawing is smooth for the current/local client. However, when displaying the pen drawing of other cursors, that is, remote users' cursors, the drawing animation isn't as smooth.

Below, the right side shows what a user would see when drawing with their own cursor. On the left is what would be displayed for another user.

pen

Why:

Improving this can improve the UX for anyone who may want to experiment with this SDK example. Furthermore, if this example were to be incorporated into the Yorkie homepage, it is even more important that it gives Yorkie users a high-quality UX.

@YoonKiJin YoonKiJin added the enhancement 🌟 New feature or request label Aug 10, 2023
@krapie
Copy link
Member

krapie commented Aug 10, 2023

Can I get some explanation about why this is happening?
Is it because there is some kind of throttle when passing the cursor position between peers?

@YoonKiJin
Copy link
Contributor Author

YoonKiJin commented Aug 10, 2023

After experimenting with what values are being sent from local to remote cursors and logging what is being received, it seems that all x y values of all cursors currently on the screen are being sent and received properly. The issue seems be due to how the drawing is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants