Reverse TreeChanges when Deleting in Tree #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
approved these changes
Apr 12, 2024
hackerwins
changed the title
hackerwins
changed the title
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR addresses the issue where, in a tree data structure, when range deletion operations occur and are split into multiple events by
makeDeletionChanges, the order of events needs to be reversed. If you don't reverse the order, you may lead to situations where adjustments to the range are necessary for subscribers of the events.More detailed information on this scenario can be found in issue #773.
Any background context you want to provide?
When range deletion operations result in multiple events due to the
makeDeletionChanges()function, in order to prevent issues for subscribers handling these events, the order of events must be reversed. By reversing the order of events, there is no need to adjust the range of the next event by the previous event.What are the relevant tickets?
Fixes #773
Checklist