Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "full-screen" modal type #121

Open
bashmish opened this issue Sep 8, 2022 · 0 comments
Open

Add "full-screen" modal type #121

bashmish opened this issue Sep 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@bashmish
Copy link

bashmish commented Sep 8, 2022

I'd like to have a modal which will take the full width and height of the plugin.

Right now I'm solving this with position="left" and some extra styles:

<Modal position="left" noTransition={true}>
  <div
    style={{
      width: '100vw',
      height: 'calc(100vh - 41px)',
      overflowY: 'auto',
    }}
  >
    {/* content goes here */}
  </div>
</Modal>

41px is the height of the modal top bar (magical, since I didn't find a CSS var for it).

I think it's much better to have such modal type out-of-the-box and not use magical number.
position="left" also breaks transition for me, because I want the center transition, not left, but center has border-radius on the modal which I can't remove on my side.

@yuanqing yuanqing added the enhancement New feature or request label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants