Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly unecessary dependency from yudai/pp on unmarshaler_test.go #44

Open
luccamendonca opened this issue Oct 27, 2021 · 2 comments
Open

Comments

@luccamendonca
Copy link

Hey!

I'm packaging a go app on Debian (kong/deck) which depends on gojsondiff.
It shouldn't be a big problem, but it introduces an indirect dependency, forcing me to also package your pp fork which doesn't seem like a great idea right now (specially because the upstream is actively maintained, while the for isn't).

Would it be okay for me to open a PR removing the dependency or even importing the upstream pp (which is already distributed on Debian)? :)

Thanks!

@balogal
Copy link

balogal commented Mar 31, 2022

Hi, to expand on this issue the yudai/pp fork does not contain a LICENSE file. Unfortunately, this prevents me from using yudai/pp and all packages that (transitively) depend on it, for legal reasons.

Swapping yudai/pp for the upstream k0kubun/pp, completely dropping pp or adding a LICENSE file to yudai/pp would all be suitable solutions for me. However, I would prefer options one or two for the reasons brought up by @luccamendonca.

It would be really great if we can make this change happen. I'm also up for contributing it myself if there is the chance that you accept it @yudai.

@balogal
Copy link

balogal commented Apr 8, 2022

In case someone stumbles over this: As a workaround, I added a replace directive to my go.mod file that replaces the yudai/pp fork with its upstream dependency and it works as expected.

replace github.com/yudai/pp => github.com/k0kubun/pp v3.0.1+incompatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants