You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm packaging a go app on Debian (kong/deck) which depends on gojsondiff.
It shouldn't be a big problem, but it introduces an indirect dependency, forcing me to also package your pp fork which doesn't seem like a great idea right now (specially because the upstream is actively maintained, while the for isn't).
Would it be okay for me to open a PR removing the dependency or even importing the upstream pp (which is already distributed on Debian)? :)
Thanks!
The text was updated successfully, but these errors were encountered:
Hi, to expand on this issue the yudai/pp fork does not contain a LICENSE file. Unfortunately, this prevents me from using yudai/pp and all packages that (transitively) depend on it, for legal reasons.
Swapping yudai/pp for the upstream k0kubun/pp, completely dropping pp or adding a LICENSE file to yudai/pp would all be suitable solutions for me. However, I would prefer options one or two for the reasons brought up by @luccamendonca.
It would be really great if we can make this change happen. I'm also up for contributing it myself if there is the chance that you accept it @yudai.
In case someone stumbles over this: As a workaround, I added a replace directive to my go.mod file that replaces the yudai/pp fork with its upstream dependency and it works as expected.
Hey!
I'm packaging a go app on Debian (kong/deck) which depends on
gojsondiff
.It shouldn't be a big problem, but it introduces an indirect dependency, forcing me to also package your
pp
fork which doesn't seem like a great idea right now (specially because the upstream is actively maintained, while the for isn't).Would it be okay for me to open a PR removing the dependency or even importing the upstream
pp
(which is already distributed on Debian)? :)Thanks!
The text was updated successfully, but these errors were encountered: