Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to distribute skins #54

Open
icbmike opened this issue Dec 17, 2012 · 3 comments
Open

Add ability to distribute skins #54

icbmike opened this issue Dec 17, 2012 · 3 comments
Assignees
Labels

Comments

@icbmike
Copy link

icbmike commented Dec 17, 2012

We use yui widgets in our web apps, and we want to reskin the basic widgets. We can do that easily enough, but we want to separate our code from the YUI source.

Is it possible to add the ability to specify where to look for skins?

@ghost ghost assigned davglass Dec 17, 2012
@davglass
Copy link
Member

Currently shifter assumes that all module data lives under that modules directory. I don't feel that this would be a valid option since this would/could lead to all kinds of issues.

Give me an example and use case that I can work with and I will think it over.

@icbmike
Copy link
Author

icbmike commented Dec 17, 2012

Ok, an example:

We use the DataTable widget in probably all our web apps. We apply our own skin which is brand colored and such. We want to be able to maintain the assets for our skin separate from the YUI source that we pull from GitHub, so that there is a clean separation between our code and YUI's, and then when we build YUI it will have our skin as an option.

This could also help provide more flexibility about how we manage our skin project, for example, we'd like to use Compass to generate the CSS, and would probably want to keep the source SCSS files separate from the generated CSS files too.

@davglass
Copy link
Member

So if I added a --global-skin-dir=/my/global/skins/ config that would point to a directory like:

/my/global/skins/
   datatable/
       foo/
       bar/
       baz/

Then shifter would walk the skins in both 'src/datatable/assets/' and /my/global/skins/datatable/ and generate skins into build/datatable/assets/

Would that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants