Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests requiring a JS file with public in its name are failing #51

Open
dpobel opened this issue Jun 18, 2013 · 2 comments
Open

Unit tests requiring a JS file with public in its name are failing #51

dpobel opened this issue Jun 18, 2013 · 2 comments
Milestone

Comments

@dpobel
Copy link

dpobel commented Jun 18, 2013

If a unit test HTML file requires a JS file with a path containing /public/, this JS file is not imported because Yeti tries to use its own file in this case and thus the test is likely to fail...
It seems like it is due to this route https://github.com/yui/yeti/blob/master/lib/hub/index.js#L345

@dpobel
Copy link
Author

dpobel commented Aug 1, 2013

As I'm really annoyed by this issue, I'd like to provide a fix (or at least try to). On my setup, I have renamed the public folder in _public and have adapted the code in various places to match this rename.

Would a fix like this be sufficient or does it feel too much as a quick workaround ?

@ghost ghost assigned reid Aug 1, 2013
@reid
Copy link
Contributor

reid commented Aug 1, 2013

Hey @dpobel, I'm writing a test to catch this bug. I think we can either fix the bad route regex or use an obnoxious name like __yeti__ instead of public that nobody will ever use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants