Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use click event #350

Merged
merged 1 commit into from Apr 16, 2022
Merged

Use click event #350

merged 1 commit into from Apr 16, 2022

Conversation

aki77
Copy link
Contributor

@aki77 aki77 commented Apr 16, 2022

If a Dropdown element is scrollable, an attempt to scroll it from a touch devise will trigger the touchstart event.
I don't think it would be a problem to change it to a click event, but what do you think?

@yuku
Copy link
Owner

yuku commented Apr 16, 2022

I forget why I chose touchstart and mousedown instead of click here though it sounds good to me.

@yuku yuku merged commit 8d970fc into yuku:main Apr 16, 2022
@aki77 aki77 deleted the dev branch April 17, 2022 10:17
@aki77
Copy link
Contributor Author

aki77 commented Apr 17, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants