.github/workflows/ci.yml

@@ -0,0 +1,35 @@
+name: ci
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        go: [ '1.14', '1.13' ]
+    name: ${{ matrix.go }}
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Setup go
+        uses: actions/setup-go@v1
+        with:
+          go-version: ${{ matrix.go }}
+
+      - run: make download-ci-tools
+
+      - env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: make lint-ci
+
+      - run: make test
+
+      - run: make vet
+
+      - uses: codecov/codecov-action@v1
+        with:
+          files: ./coverage.txt
+          flags: unittests
+          name: codecov-umbrella-${{ matrix.go }}
+          fail_ci_if_error: true
+          verbose: true

.gitignore

@@ -1,2 +1,3 @@
-dist/
-vendor/
+bin/
+
+coverage.txt

Makefile

@@ -1,34 +1,45 @@
-REVISION = $(shell git rev-parse --short HEAD)
-GOLANGCI_LINT=hack/bin/golangci-lint
-GO111MODULE=on
+FMT_DIRS:=$(shell go list -f {{.Dir}} ./...)
 
-all: pre test
+.PHONY: all
+all: check test
 
-pre: fmt lint vet
+.PHONY: check
+check: fmt lint vet
 
+.PHONY: download-ci-tools
+download-ci-tools:
+	go get -u golang.org/x/tools/cmd/goimports
+	wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.36.0
+	wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s v0.11.0
+
+.PHONY: fmt
 fmt:
-	go fmt ./...
+	@gofmt -l -w -s $(FMT_DIRS)
+	@goimports -w $(FMT_DIRS)
+
+.PHONY: lint
+lint:
+	./bin/golangci-lint run ./...
 
-lint: $(GOLANGCI_LINT)
-	$(GOLANGCI_LINT) run ./...
+.PHONY: lint-ci
+lint-ci:
+	./bin/golangci-lint run ./... | \
+	./bin/reviewdog -f=golangci-lint -reporter=github-pr-review -filter-mode=nofilter
 
+.PHONY: vet
 vet:
 	go vet $$(go list ./... | grep -v /vendor/)
 
+.PHONY: test
 test:
-	go test -cover -v -race -timeout 10s ./...
+	go test -cover -coverprofile=coverage.txt -covermode=atomic -v -race -timeout 10s ./...
 
+.PHONY: bench
 bench:
 	go test -bench . -benchmem -gcflags="-m -m -l" ./...
 
+.PHONY: example
 example:
-	go build -i -v -o dist/server_demo ./example/server_demo/...
-	go build -i -v -o dist/client_demo ./example/client_demo/...
-
-$(GOLANGCI_LINT):
-	cd ./hack; \
-	go build -v \
-		-o ./bin/golangci-lint \
-		github.com/golangci/golangci-lint/cmd/golangci-lint
-
-.PHONY: all pre fmt lint vet test bench example
+	make -C example/server_demo
+	make -C example/server_relay_demo
+	make -C example/client_demo

README.md

@@ -1,7 +1,7 @@
 # go-rtmp
 
-[![CircleCI](https://circleci.com/gh/yutopp/go-rtmp.svg?style=svg)](https://circleci.com/gh/yutopp/go-rtmp)
-[![Coverage Status](https://coveralls.io/repos/github/yutopp/go-rtmp/badge.svg)](https://coveralls.io/github/yutopp/go-rtmp)
+[![ci](https://github.com/yutopp/go-rtmp/workflows/ci/badge.svg)](https://github.com/yutopp/go-rtmp/actions?query=workflow%3Aci)
+[![codecov](https://codecov.io/gh/yutopp/go-rtmp/branch/master/graph/badge.svg?token=KXgQ1x8BQP)](https://codecov.io/gh/yutopp/go-rtmp)
 [![GoDoc](https://godoc.org/github.com/yutopp/go-rtmp?status.svg)](http://godoc.org/github.com/yutopp/go-rtmp)
 [![Go Report Card](https://goreportcard.com/badge/github.com/yutopp/go-rtmp)](https://goreportcard.com/report/github.com/yutopp/go-rtmp)
 [![license](https://img.shields.io/github/license/yutopp/go-rtmp.svg)](https://github.com/yutopp/go-rtmp/blob/master/LICENSE_1_0.txt)
@@ -16,6 +16,14 @@ RTMP 1.0 server/client library written in Go.
 go get github.com/yutopp/go-rtmp
 ```
 
+See also [server_demo](https://github.com/yutopp/go-rtmp/tree/master/example/server_demo) and [client_demo](https://github.com/yutopp/go-rtmp/blob/master/example/client_demo/main.go).
+
+## Documentation
+
+- [GoDoc](https://pkg.go.dev/github.com/yutopp/go-rtmp)
+- [REAL-TIME MESSAGING PROTOCOL (RTMP) SPECIFICATION](https://www.adobe.com/devnet/rtmp.html)
+
+
 ## NOTES
 
 ### How to limit bitrates or set timeouts
@@ -25,7 +33,3 @@ go get github.com/yutopp/go-rtmp
 ## License
 
 [Boost Software License - Version 1.0](./LICENSE_1_0.txt)
-
-## References
-
-- [spec](https://wwwimages2.adobe.com/www.adobe.com/content/dam/acom/en/devnet/rtmp/pdf/rtmp_specification_1.0.pdf)

chunk_header_test.go

@@ -9,8 +9,9 @@ package rtmp
 
 import (
 	"bytes"
-	"github.com/stretchr/testify/assert"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
 func TestChunkBasicHeader(t *testing.T) {
@@ -20,7 +21,7 @@ func TestChunkBasicHeader(t *testing.T) {
 		binary []byte
 	}
 	testCases := []testCase{
-		testCase{
+		{
 			name: "cs normal 1",
 			value: &chunkBasicHeader{
 				fmt:           1,
@@ -32,7 +33,7 @@ func TestChunkBasicHeader(t *testing.T) {
 				0x42,
 			},
 		},
-		testCase{
+		{
 			name: "cs normal 2",
 			value: &chunkBasicHeader{
 				fmt:           2,
@@ -45,7 +46,7 @@ func TestChunkBasicHeader(t *testing.T) {
 			},
 		},
 
-		testCase{
+		{
 			name: "cs medium 1",
 			value: &chunkBasicHeader{
 				fmt:           0,
@@ -60,7 +61,7 @@ func TestChunkBasicHeader(t *testing.T) {
 				0x00,
 			},
 		},
-		testCase{
+		{
 			name: "cs medium 2",
 			value: &chunkBasicHeader{
 				fmt:           1,
@@ -75,7 +76,7 @@ func TestChunkBasicHeader(t *testing.T) {
 			},
 		},
 
-		testCase{
+		{
 			name: "cs large 1",
 			value: &chunkBasicHeader{
 				fmt:           3,
@@ -90,7 +91,7 @@ func TestChunkBasicHeader(t *testing.T) {
 				0x00, 0x01,
 			},
 		},
-		testCase{
+		{
 			name: "cs large 2",
 			value: &chunkBasicHeader{
 				fmt:           0,
@@ -190,7 +191,7 @@ func TestChunkMessageHeader(t *testing.T) {
 		binary []byte
 	}
 	testCases := []testCase{
-		testCase{
+		{
 			name: "basic fmt 0",
 			fmt:  0,
 			value: &chunkMessageHeader{
@@ -210,7 +211,7 @@ func TestChunkMessageHeader(t *testing.T) {
 				0x0a, 0x00, 0x00, 0x00,
 			},
 		},
-		testCase{
+		{
 			name: "basic fmt 1",
 			fmt:  1,
 			value: &chunkMessageHeader{
@@ -227,7 +228,7 @@ func TestChunkMessageHeader(t *testing.T) {
 				0x0a,
 			},
 		},
-		testCase{
+		{
 			name: "basic fmt 2",
 			fmt:  2,
 			value: &chunkMessageHeader{
@@ -239,7 +240,7 @@ func TestChunkMessageHeader(t *testing.T) {
 			},
 		},
 
-		testCase{
+		{
 			name: "extended boundary fmt 0",
 			fmt:  0,
 			value: &chunkMessageHeader{
@@ -261,7 +262,7 @@ func TestChunkMessageHeader(t *testing.T) {
 				0x00, 0xff, 0xff, 0xff,
 			},
 		},
-		testCase{
+		{
 			name: "extended boundary fmt 1",
 			fmt:  1,
 			value: &chunkMessageHeader{
@@ -280,7 +281,7 @@ func TestChunkMessageHeader(t *testing.T) {
 				0x00, 0xff, 0xff, 0xff,
 			},
 		},
-		testCase{
+		{
 			name: "extended boundary fmt 2",
 			fmt:  2,
 			value: &chunkMessageHeader{
@@ -294,7 +295,7 @@ func TestChunkMessageHeader(t *testing.T) {
 			},
 		},
 
-		testCase{
+		{
 			name: "extended fmt 0",
 			fmt:  0,
 			value: &chunkMessageHeader{
@@ -316,7 +317,7 @@ func TestChunkMessageHeader(t *testing.T) {
 				0x01, 0x00, 0x00, 0x00,
 			},
 		},
-		testCase{
+		{
 			name: "extended fmt 1",
 			fmt:  1,
 			value: &chunkMessageHeader{
@@ -335,7 +336,7 @@ func TestChunkMessageHeader(t *testing.T) {
 				0x01, 0x00, 0x00, 0x00,
 			},
 		},
-		testCase{
+		{
 			name: "extended fmt 2",
 			fmt:  2,
 			value: &chunkMessageHeader{
@@ -349,7 +350,7 @@ func TestChunkMessageHeader(t *testing.T) {
 			},
 		},
 
-		testCase{
+		{
 			name:   "fmt 3",
 			fmt:    3,
 			value:  &chunkMessageHeader{},

chunk_streamer.go

@@ -9,13 +9,14 @@ package rtmp
 
 import (
 	"context"
-	"github.com/pkg/errors"
-	"github.com/sirupsen/logrus"
 	"io"
 	"math"
 	"sync"
 	"time"
 
+	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
+
 	"github.com/yutopp/go-rtmp/message"
 )